Reland: Fix WebViewPlugin::scheduleAnimation crash

content/renderer/pepper/pepper_webplugin_impl.h

Index: content/renderer/pepper/pepper_webplugin_impl.h
diff --git a/content/renderer/pepper/pepper_webplugin_impl.h b/content/renderer/pepper/pepper_webplugin_impl.h
index 9b90e8be24a4511a7cd8540377e12bcb2c8ffb94..86fd567138de67ada91f8811d7ebcdfd0d8843aa 100644
--- a/content/renderer/pepper/pepper_webplugin_impl.h
+++ b/content/renderer/pepper/pepper_webplugin_impl.h
@@ -101,10 +101,10 @@ class PepperWebPluginImpl : public blink::WebPlugin {
   // True if the instance represents the entire document in a frame instead of
   // being an embedded resource.
   bool full_frame_;
-  scoped_ptr<PluginInstanceThrottlerImpl> throttler_;
   scoped_refptr<PepperPluginInstanceImpl> instance_;
   gfx::Rect plugin_rect_;
   PP_Var instance_object_;
+  scoped_ptr<PluginInstanceThrottlerImpl> throttler_;

[tommycli, 2015/05/13 22:07:02]

I think this isn't quite necessary.

This throttler_ is set before the plugin itself is initialized. Once the plugin
instance_ is initialized, the throttler ownership passes to the instance_, and
this member is null.

If this is non-null in destroy(), it means the plugin was never initialized.

[trchen, 2015/05/13 22:17:04]

Yep. Actually all changes in PepperWebPluginImpl are probably no-op. I made the
change anyway just as a matter of principle. (Comforting my OCD...)

Though what really matters is we need more test coverage in this area. I
actually wanted to write a test for this, but couldn't find a template to
initialize a frame with plugins. Do you have good ideas?

   blink::WebPluginContainer* container_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperWebPluginImpl);