Reland: Fix WebViewPlugin::scheduleAnimation crash

content/renderer/pepper/pepper_webplugin_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_PEPPER_PEPPER_WEBPLUGIN_IMPL_H_
 #define CONTENT_RENDERER_PEPPER_PEPPER_WEBPLUGIN_IMPL_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 83 matching lines @@
  private:
   friend class base::DeleteHelper<PepperWebPluginImpl>;
 
   virtual ~PepperWebPluginImpl();
   struct InitData;
 
   scoped_ptr<InitData> init_data_;  // Cleared upon successful initialization.
   // True if the instance represents the entire document in a frame instead of
   // being an embedded resource.
   bool full_frame_;
-  scoped_ptr<PluginInstanceThrottlerImpl> throttler_;
   scoped_refptr<PepperPluginInstanceImpl> instance_;
   gfx::Rect plugin_rect_;
   PP_Var instance_object_;
+  scoped_ptr<PluginInstanceThrottlerImpl> throttler_;

[tommycli, 2015/05/13 22:07:02]

I think this isn't quite necessary.

This throttler_ is set before the plugin itself is initialized. Once the plugin
instance_ is initialized, the throttler ownership passes to the instance_, and
this member is null.

If this is non-null in destroy(), it means the plugin was never initialized.

[trchen, 2015/05/13 22:17:04]

Yep. Actually all changes in PepperWebPluginImpl are probably no-op. I made the
change anyway just as a matter of principle. (Comforting my OCD...)

Though what really matters is we need more test coverage in this area. I
actually wanted to write a test for this, but couldn't find a template to
initialize a frame with plugins. Do you have good ideas?

   blink::WebPluginContainer* container_;
 
   DISALLOW_COPY_AND_ASSIGN(PepperWebPluginImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_PEPPER_PEPPER_WEBPLUGIN_IMPL_H_