Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 1141683003: Don't dispatch two 'load' events for external SVGScriptElement loads (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr.
CC:
blink-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't dispatch two 'load' events for external SVGScriptElement loads If inserting an <svg:script> reference an external source via script, ScriptLoaded would dispatch 'load' and then SVGScriptElement would do the same. Drop the latter one. Since this makes SVGScriptElement no longer use SVGElement::sendSVGLoadEventIfPossibleAsynchronously(), drop the svgLoadEventTimer() override and associated timer. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195604

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
A LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html View 1 chunk +22 lines, -0 lines 2 comments Download
A + LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
https://codereview.chromium.org/1141683003/diff/1/LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html File LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html (right): https://codereview.chromium.org/1141683003/diff/1/LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html#newcode12 LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html:12: setTimeout(function() { Not very fond of this, but did ...
5 years, 7 months ago (2015-05-19 07:25:40 UTC) #2
pdr.
LGTM. Nice! https://codereview.chromium.org/1141683003/diff/1/LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html File LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html (right): https://codereview.chromium.org/1141683003/diff/1/LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html#newcode12 LayoutTests/svg/dom/SVGScriptElement/script-external-no-multiple-load.html:12: setTimeout(function() { On 2015/05/19 at 07:25:40, fs ...
5 years, 7 months ago (2015-05-19 18:18:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141683003/1
5 years, 7 months ago (2015-05-20 07:48:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 09:03:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195604

Powered by Google App Engine
This is Rietveld 408576698