Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Side by Side Diff: Source/core/svg/SVGScriptElement.cpp

Issue 1141683003: Don't dispatch two 'load' events for external SVGScriptElement loads (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 17 matching lines...) Expand all
28 #include "core/dom/Attribute.h" 28 #include "core/dom/Attribute.h"
29 #include "core/dom/ScriptLoader.h" 29 #include "core/dom/ScriptLoader.h"
30 #include "core/dom/ScriptRunner.h" 30 #include "core/dom/ScriptRunner.h"
31 #include "core/events/Event.h" 31 #include "core/events/Event.h"
32 32
33 namespace blink { 33 namespace blink {
34 34
35 inline SVGScriptElement::SVGScriptElement(Document& document, bool wasInsertedBy Parser, bool alreadyStarted) 35 inline SVGScriptElement::SVGScriptElement(Document& document, bool wasInsertedBy Parser, bool alreadyStarted)
36 : SVGElement(SVGNames::scriptTag, document) 36 : SVGElement(SVGNames::scriptTag, document)
37 , SVGURIReference(this) 37 , SVGURIReference(this)
38 , m_svgLoadEventTimer(this, &SVGElement::svgLoadEventTimerFired)
39 , m_loader(ScriptLoader::create(this, wasInsertedByParser, alreadyStarted)) 38 , m_loader(ScriptLoader::create(this, wasInsertedByParser, alreadyStarted))
40 { 39 {
41 } 40 }
42 41
43 PassRefPtrWillBeRawPtr<SVGScriptElement> SVGScriptElement::create(Document& docu ment, bool insertedByParser) 42 PassRefPtrWillBeRawPtr<SVGScriptElement> SVGScriptElement::create(Document& docu ment, bool insertedByParser)
44 { 43 {
45 return adoptRefWillBeNoop(new SVGScriptElement(document, insertedByParser, f alse)); 44 return adoptRefWillBeNoop(new SVGScriptElement(document, insertedByParser, f alse));
46 } 45 }
47 46
48 void SVGScriptElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 47 void SVGScriptElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
(...skipping 18 matching lines...) Expand all
67 Node::InsertionNotificationRequest SVGScriptElement::insertedInto(ContainerNode* rootParent) 66 Node::InsertionNotificationRequest SVGScriptElement::insertedInto(ContainerNode* rootParent)
68 { 67 {
69 SVGElement::insertedInto(rootParent); 68 SVGElement::insertedInto(rootParent);
70 return InsertionShouldCallDidNotifySubtreeInsertions; 69 return InsertionShouldCallDidNotifySubtreeInsertions;
71 } 70 }
72 71
73 void SVGScriptElement::didNotifySubtreeInsertionsToDocument() 72 void SVGScriptElement::didNotifySubtreeInsertionsToDocument()
74 { 73 {
75 m_loader->didNotifySubtreeInsertionsToDocument(); 74 m_loader->didNotifySubtreeInsertionsToDocument();
76 75
77 if (!m_loader->isParserInserted()) { 76 if (!m_loader->isParserInserted())
78 m_loader->setHaveFiredLoadEvent(true); 77 m_loader->setHaveFiredLoadEvent(true);
79 sendSVGLoadEventIfPossibleAsynchronously();
80 }
81 } 78 }
82 79
83 void SVGScriptElement::childrenChanged(const ChildrenChange& change) 80 void SVGScriptElement::childrenChanged(const ChildrenChange& change)
84 { 81 {
85 SVGElement::childrenChanged(change); 82 SVGElement::childrenChanged(change);
86 m_loader->childrenChanged(); 83 m_loader->childrenChanged();
87 } 84 }
88 85
89 void SVGScriptElement::didMoveToNewDocument(Document& oldDocument) 86 void SVGScriptElement::didMoveToNewDocument(Document& oldDocument)
90 { 87 {
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 #endif 171 #endif
175 172
176 DEFINE_TRACE(SVGScriptElement) 173 DEFINE_TRACE(SVGScriptElement)
177 { 174 {
178 visitor->trace(m_loader); 175 visitor->trace(m_loader);
179 SVGElement::trace(visitor); 176 SVGElement::trace(visitor);
180 SVGURIReference::trace(visitor); 177 SVGURIReference::trace(visitor);
181 } 178 }
182 179
183 } // namespace blink 180 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698