chrome/browser/sync_file_system/drive_file_sync_service.h - Issue 11416339: Sync FileSystem: Update polling delay when remote change-list did not update change_queue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_file_sync_service.h

Issue 11416339: Sync FileSystem: Update polling delay when remote change-list did not update change_queue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync_file_system/drive_file_sync_service.h

diff --git a/chrome/browser/sync_file_system/drive_file_sync_service.h b/chrome/browser/sync_file_system/drive_file_sync_service.h

index ad215642b19a2b9efe977d242b5166551f32c430..cb0c22f730d12fa8d79407f1351605a49e16de49 100644

--- a/chrome/browser/sync_file_system/drive_file_sync_service.h

+++ b/chrome/browser/sync_file_system/drive_file_sync_service.h

@@ -280,7 +280,7 @@ class DriveFileSyncService

scoped_ptr<ProcessRemoteChangeParam> param,

fileapi::SyncStatusCode status);

- void AppendNewRemoteChange(const GURL& origin,

+ bool AppendNewRemoteChange(const GURL& origin,

kinuko 2012/12/04 10:23:27 Can you add a short comment when this returns true

tzik 2012/12/04 10:32:03 Done. Wrote comments in .h.

const google_apis::DocumentEntry& entry,

int64 changestamp,

RemoteSyncType sync_type);

@@ -301,6 +301,7 @@ class DriveFileSyncService

void FetchChangesForIncrementalSync();

void DidFetchChangesForIncrementalSync(

scoped_ptr<TaskToken> token,

+ bool queue_was_updated,

kinuko 2012/12/04 10:23:27 had_new_changes maybe? (the term 'queue' sounds a

tzik 2012/12/04 10:32:03 Done.

google_apis::GDataErrorCode error,

scoped_ptr<google_apis::DocumentFeed> changes);

bool GetOriginForEntry(const google_apis::DocumentEntry& entry, GURL* origin);

« no previous file with comments | « no previous file | chrome/browser/sync_file_system/drive_file_sync_service.cc » ('j') | no next file with comments »