Sync FileSystem: Update polling delay when remote change-list did not update change_queue.

chrome/browser/sync_file_system/drive_file_sync_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_FILE_SYNC_SERVICE_H_
 #define CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_FILE_SYNC_SERVICE_H_
 
 #include <deque>
 #include <map>
 #include <set>
@@ skipping 262 matching lines @@
   void CompleteRemoteSync(
       scoped_ptr<ProcessRemoteChangeParam> param,
       fileapi::SyncStatusCode status);
   void AbortRemoteSync(
       scoped_ptr<ProcessRemoteChangeParam> param,
       fileapi::SyncStatusCode status);
   void FinalizeRemoteSync(
       scoped_ptr<ProcessRemoteChangeParam> param,
       fileapi::SyncStatusCode status);
 
-  void AppendNewRemoteChange(const GURL& origin,
+  bool AppendNewRemoteChange(const GURL& origin,

[kinuko, 2012/12/04 10:23:27]

Can you add a short comment when this returns true/false?

[tzik, 2012/12/04 10:32:03]

Done. Wrote comments in .h.

                              const google_apis::DocumentEntry& entry,
                              int64 changestamp,
                              RemoteSyncType sync_type);
   void RemoveRemoteChange(const fileapi::FileSystemURL& url);
   void MaybeMarkAsIncrementalSyncOrigin(const GURL& origin);
 
   // This returns false if no change is found for the |url|.
   bool GetPendingChangeForFileSystemURL(const fileapi::FileSystemURL& url,
                                         RemoteChange* change) const;
 
   // A wrapper implementation to GDataErrorCodeToSyncStatusCode which returns
   // authentication error if the user is not signed in.
   fileapi::SyncStatusCode GDataErrorCodeToSyncStatusCodeWrapper(
       google_apis::GDataErrorCode error) const;
 
   FilePath temporary_file_dir_;
 
   void FetchChangesForIncrementalSync();
   void DidFetchChangesForIncrementalSync(
       scoped_ptr<TaskToken> token,
+      bool queue_was_updated,

[kinuko, 2012/12/04 10:23:27]

had_new_changes maybe? (the term 'queue' sounds a bit too generic)

[tzik, 2012/12/04 10:32:03]

Done.

       google_apis::GDataErrorCode error,
       scoped_ptr<google_apis::DocumentFeed> changes);
   bool GetOriginForEntry(const google_apis::DocumentEntry& entry, GURL* origin);
   void SchedulePolling();
 
   scoped_ptr<DriveMetadataStore> metadata_store_;
   scoped_ptr<DriveFileSyncClient> sync_client_;
 
   fileapi::SyncStatusCode last_operation_status_;
   RemoteServiceState state_;
@@ skipping 22 matching lines @@
   // Use WeakPtrFactory instead of SupportsWeakPtr to revoke the weak pointer
   // in |token_|.
   base::WeakPtrFactory<DriveFileSyncService> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(DriveFileSyncService);
 };
 
 }  // namespace sync_file_system
 
 #endif  // CHROME_BROWSER_SYNC_FILE_SYSTEM_DRIVE_FILE_SYNC_SERVICE_H_