content/browser/web_contents/web_contents_impl.cc - Issue 11416187: Commit instant loader when the instant page navigates away from instant URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11416187: Commit instant loader when the instant page navigates away from instant URL. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Merging in sreeram's changes. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_client.cc ('K') | « chrome/browser/instant/instant_tab.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | content/public/browser/web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index e4e4e6d7ccd0b3881dd0b5398fbb1d93ae68bea5..785e48544ca8501b5e09f6bdc458abbee5250113 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1560,6 +1560,9 @@ WebContents* WebContentsImpl::OpenURL(const OpenURLParams& params) {

if (!delegate_)

return NULL;

+ FOR_EACH_OBSERVER(WebContentsObserver, observers_,

+ AboutToOpenURL(params.url));

WebContents* new_contents = delegate_->OpenURLFromTab(this, params);

// Notify observers.

FOR_EACH_OBSERVER(WebContentsObserver, observers_,