Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2891)

Unified Diff: chrome/browser/instant/instant_client.cc

Issue 11416187: Commit instant loader when the instant page navigates away from instant URL. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Merging in sreeram's changes. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_client.cc
diff --git a/chrome/browser/instant/instant_client.cc b/chrome/browser/instant/instant_client.cc
index eb045bc7e514b5860c439896fb8c7e0862b336d2..db8639fa4b544f36b681016d0cf47538424c09b9 100644
--- a/chrome/browser/instant/instant_client.cc
+++ b/chrome/browser/instant/instant_client.cc
@@ -97,6 +97,23 @@ bool InstantClient::OnMessageReceived(const IPC::Message& message) {
return handled;
}
+void InstantClient::DidCommitProvisionalLoadForFrame(
+ int64 frame_id,
+ bool is_main_frame,
+ const GURL& url,
+ content::PageTransition transition_type,
+ content::RenderViewHost* render_view_host) {
+ if (!is_main_frame)
+ return;
+ LOG(ERROR) << "***** DidCommitProvisionalLoadForFrame: " << url;
sky 2012/12/06 22:37:29 remove logging.
Shishir 2012/12/06 23:20:30 Done.
+ delegate_->InstantClientAboutToNavigate(url);
sky 2012/12/06 22:37:29 Maybe name this InstantClientAboutToNativeMainFram
Shishir 2012/12/06 23:20:30 Changed to AboutToNativeMainFrame as Samarth point
+}
+
+void InstantClient::AboutToOpenURL(const GURL& url) {
+ LOG(ERROR) << "***** AboutToOpenURL: " << url;
+ delegate_->InstantClientAboutToNavigate(url);
+}
+
void InstantClient::SetSuggestions(
int page_id,
const std::vector<InstantSuggestion>& suggestions) {

Powered by Google App Engine
This is Rietveld 408576698