[Mac] Prevent ppapi fullscreen window from dealloc while on stack.

content/browser/renderer_host/render_widget_host_view_mac.mm

Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index f9e65b8c2c9582eec7e1346cb21dbc34e4d1df4d..22340948ecee61fe97750dc3bc9f881ae170f3b1 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -728,7 +728,7 @@ void RenderWidgetHostViewMac::Destroy() {
   [fullscreen_window_manager_ exitFullscreenMode];
   fullscreen_window_manager_.reset();
   [pepper_fullscreen_window_ close];
-  pepper_fullscreen_window_.reset();
+  pepper_fullscreen_window_.autorelease();

[Robert Sesek, 2012/11/16 18:07:43]

Ooh. When did this get born?

[Robert Sesek, 2012/11/16 18:07:43]

Does this window have a delegate that the window could now outlive?

[Scott Hess - ex-Googler, 2012/11/16 18:17:37]

Pretty recent.  I had rewritten a piece of code three ways and thought "Maybe
this is too much freedom."

[Scott Hess - ex-Googler, 2012/11/16 18:17:37]

AFAICT, no.  fullscreen_window_manager_ may have a reference to this window, but
the window doesn't have any controller or delegate or anything.  Which makes
sense, as it only exists to cover the screen, you can't interact with it.

[sail, 2012/11/16 19:59:02]

Could you add a comment here saying that on shutdown this object is still being
referenced earlier in the stack.

 
   // We get this call just before |render_widget_host_| deletes
   // itself.  But we are owned by |cocoa_view_|, which may be retained