[Mac] Prevent ppapi fullscreen window from dealloc while on stack.

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 710 matching lines @@
   }
 
   // We've been told to destroy.
   [cocoa_view_ retain];
   [cocoa_view_ removeFromSuperview];
   [cocoa_view_ autorelease];
 
   [fullscreen_window_manager_ exitFullscreenMode];
   fullscreen_window_manager_.reset();
   [pepper_fullscreen_window_ close];
-  pepper_fullscreen_window_.reset();
+  pepper_fullscreen_window_.autorelease();

[Robert Sesek, 2012/11/16 18:07:43]

Ooh. When did this get born?

[Robert Sesek, 2012/11/16 18:07:43]

Does this window have a delegate that the window could now outlive?

[Scott Hess - ex-Googler, 2012/11/16 18:17:37]

Pretty recent.  I had rewritten a piece of code three ways and thought "Maybe
this is too much freedom."

[Scott Hess - ex-Googler, 2012/11/16 18:17:37]

AFAICT, no.  fullscreen_window_manager_ may have a reference to this window, but
the window doesn't have any controller or delegate or anything.  Which makes
sense, as it only exists to cover the screen, you can't interact with it.

[sail, 2012/11/16 19:59:02]

Could you add a comment here saying that on shutdown this object is still being
referenced earlier in the stack.

 
   // We get this call just before |render_widget_host_| deletes
   // itself.  But we are owned by |cocoa_view_|, which may be retained
   // by some other code.  Examples are WebContentsViewMac's
   // |latent_focus_view_| and TabWindowController's
   // |cachedContentView_|.
   render_widget_host_ = NULL;
 }
 
 // Called from the renderer to tell us what the tooltip text should be. It
@@ skipping 2620 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end