Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1141553006: Update Blink to use the tree scope info on WebFrame for scoping checks. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
hayato
CC:
dcheng, blink-reviews, dglazkov+blink, mlamouri+watch-blink_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update Blink to use the tree scope info on WebFrame for scoping checks. This patch switches FrameTree over to using the tree scope information that's now tracked in WebFrame. This removes the dependency on using the DOM to check if a nested browsing context is in a shadow tree, so the scoping checks for remote frames can be re-enabled. The rest of this change is just updating callsites for functions with new signatures, as well as deleting now-obsolete code. BUG=473518 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195765 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195798

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -122 lines) Patch
M Source/core/frame/LocalFrame.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/core/page/FrameTree.cpp View 2 chunks +10 lines, -38 lines 0 comments Download
M Source/web/WebEmbeddedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +4 lines, -6 lines 1 comment Download
M Source/web/WebRemoteFrameImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/WebRemoteFrameImpl.cpp View 3 chunks +0 lines, -15 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ChromeClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/FrameTestHelpers.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 18 chunks +27 lines, -27 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebFrameClient.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebLocalFrame.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M public/web/WebRemoteFrame.h View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
This is the Blink-side patch which cleans up the temporary overloads and switches FrameTree over ...
5 years, 7 months ago (2015-05-21 22:50:10 UTC) #2
hayato
lgtm
5 years, 7 months ago (2015-05-22 04:03:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553006/20001
5 years, 7 months ago (2015-05-22 04:09:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195765
5 years, 7 months ago (2015-05-22 06:23:31 UTC) #6
tkent
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1157563004/ by tkent@chromium.org. ...
5 years, 7 months ago (2015-05-22 06:53:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553006/20001
5 years, 7 months ago (2015-05-22 17:20:17 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 17:23:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195798

Powered by Google App Engine
This is Rietveld 408576698