Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: Source/bindings/core/v8/ScriptDebugServer.cpp

Issue 1141553003: DevTools: make getInternalProperties work when Debugger is not enabled (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed failing test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/core/v8/ScriptDebugServer.cpp b/Source/bindings/core/v8/ScriptDebugServer.cpp
index f57280ddb1627b7d51379f27ef2f1151187a2643..346a65a9eaa837352f449556672e9139a3a4745c 100644
--- a/Source/bindings/core/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/core/v8/ScriptDebugServer.cpp
@@ -732,16 +732,6 @@ v8::Local<v8::Value> ScriptDebugServer::collectionEntries(v8::Local<v8::Object>&
return callDebuggerMethod("getCollectionEntries", 1, argv).ToLocalChecked();
}
-v8::Local<v8::Value> ScriptDebugServer::getInternalProperties(v8::Local<v8::Object>& object)
-{
- if (!enabled()) {
- // FIXME: provide a way to collect internal properties without enabling debugger. See crbug.com/485451
- return v8::Local<v8::Value>::New(m_isolate, v8::Undefined(m_isolate));
- }
- v8::Local<v8::Value> argv[] = { object };
- return callDebuggerMethod("getInternalProperties", 1, argv).ToLocalChecked();
-}
-
v8::MaybeLocal<v8::Value> ScriptDebugServer::setFunctionVariableValue(v8::Local<v8::Value> functionValue, int scopeNumber, const String& variableName, v8::Local<v8::Value> newValue)
{
if (m_debuggerScript.IsEmpty()) {
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.h ('k') | Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698