Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 1141553003: DevTools: make getInternalProperties work when Debugger is not enabled (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed failing test Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | Source/core/inspector/InjectedScriptSource.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp
index 03c744f92c936d9443a2fd1cd5d9d4d0a5841765..8c2687304519f14bb537ad1f0176d2fc9c73f9b3 100644
--- a/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp
@@ -300,10 +300,8 @@ void V8InjectedScriptHost::getInternalPropertiesMethodCustom(const v8::FunctionC
return;
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(info[0]);
-
- InjectedScriptHost* host = V8InjectedScriptHost::toImpl(info.Holder());
- ScriptDebugServer& debugServer = host->scriptDebugServer();
- v8SetReturnValue(info, debugServer.getInternalProperties(object));
+ v8::MaybeLocal<v8::Array> properties = v8::Debug::GetInternalProperties(info.GetIsolate(), object);
+ v8SetReturnValue(info, properties);
}
static v8::Local<v8::Array> getJSListenerFunctions(v8::Isolate* isolate, ExecutionContext* executionContext, const EventListenerInfo& listenerInfo)
« no previous file with comments | « Source/bindings/core/v8/ScriptDebugServer.cpp ('k') | Source/core/inspector/InjectedScriptSource.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698