Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141553003: DevTools: make getInternalProperties work when Debugger is not enabled (Closed)

Created:
5 years, 7 months ago by yurys
Modified:
5 years, 7 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, vivekg, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews-bindings_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: make getInternalProperties work when Debugger is not enabled Collecting object's internal properties is now possible without enabling debugger. BUG=485451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195448

Patch Set 1 #

Patch Set 2 : Fixed failing test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -45 lines) Patch
M LayoutTests/inspector-protocol/runtime/runtime-getProperties.html View 1 chunk +1 line, -7 lines 0 comments Download
M Source/bindings/core/v8/DebuggerScript.js View 1 chunk +0 lines, -14 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 1 2 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
yurys
5 years, 7 months ago (2015-05-12 09:58:00 UTC) #2
yurys
This change depends on the new V8 API.
5 years, 7 months ago (2015-05-12 09:58:28 UTC) #3
sergeyv
lgtm
5 years, 7 months ago (2015-05-12 12:33:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553003/20001
5 years, 7 months ago (2015-05-13 08:17:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/44534)
5 years, 7 months ago (2015-05-13 08:31:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553003/20001
5 years, 7 months ago (2015-05-13 14:58:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_compile_dbg/builds/8560) mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, ...
5 years, 7 months ago (2015-05-13 15:15:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553003/20001
5 years, 7 months ago (2015-05-14 11:57:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/55285)
5 years, 7 months ago (2015-05-14 12:11:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141553003/20001
5 years, 7 months ago (2015-05-18 04:11:35 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 05:20:33 UTC) #19
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195448

Powered by Google App Engine
This is Rietveld 408576698