|
Add an extension bubble explaining which extensions are in dev mode.
Note: This is a brand new changelist (the other one got corrupt somehow). Review happened here: https://codereview.chromium.org/95133002/
In order to accomplish this without too much code duplication I refactored the common code of the newly added SuspiciousExtension bubble into a base class ExtensionMessageBubbleController and a derived class (SuspiciousExtensionBubbleController) to accomodate a new type of bubble (DevModeBubbleController). I also generalized the BubbleView code to just display whatever the controller tells it (and removed mentions of SuspiciousExtensions from it).
The new controller has an action button (Disable) so new functionality was added to accomodate.
BUG= 328441
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240767
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+1403 lines, -177 lines) |
Patch |
 |
M |
chrome/app/theme/theme_resources.grd
|
View
|
1
2
3
4
5
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/dev_mode_bubble_controller.h
|
View
|
1
2
3
|
1 chunk |
+86 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/dev_mode_bubble_controller.cc
|
View
|
1
2
3
|
1 chunk |
+149 lines, -0 lines |
2 comments
|
Download
|
 |
A |
chrome/browser/extensions/extension_message_bubble.h
|
View
|
1
2
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/extension_message_bubble_controller.h
|
View
|
1
2
|
1 chunk |
+111 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/extension_message_bubble_controller.cc
|
View
|
1
2
|
1 chunk |
+151 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/extensions/extension_message_bubble_controller_unittest.cc
|
View
|
1
2
|
1 chunk |
+392 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_prefs.cc
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/suspicious_extension_bubble_controller.h
|
View
|
1
|
4 chunks |
+28 lines, -36 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/suspicious_extension_bubble_controller.cc
|
View
|
|
5 chunks |
+61 lines, -111 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/views/extensions/extension_message_bubble_view.h
|
View
|
1
2
3
4
|
4 chunks |
+25 lines, -20 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/views/extensions/extension_message_bubble_view.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+327 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_action_view.cc
|
View
|
1
2
3
4
|
2 chunks |
+10 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_actions_container.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/toolbar_view.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_extensions.gypi
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+5 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
3
4
5
6
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
extensions/common/feature_switch.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
extensions/common/feature_switch.cc
|
View
|
1
2
3
4
|
3 chunks |
+7 lines, -0 lines |
0 comments
|
Download
|
 |
M |
extensions/common/switches.h
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
extensions/common/switches.cc
|
View
|
1
2
3
4
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|