Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 114153003: Add an extension bubble explaining which extensions are in dev mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6
7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
11 #include "chrome/browser/extensions/extension_action_manager.h"
12 #include "chrome/browser/extensions/extension_prefs.h"
13 #include "chrome/browser/extensions/extension_service.h"
14 #include "chrome/browser/extensions/extension_system.h"
15 #include "chrome/browser/extensions/suspicious_extension_bubble_controller.h"
16 #include "chrome/browser/profiles/profile.h"
17 #include "chrome/browser/ui/browser.h"
18 #include "chrome/browser/ui/views/frame/browser_view.h"
19 #include "chrome/browser/ui/views/toolbar/browser_actions_container.h"
20 #include "chrome/browser/ui/views/toolbar/toolbar_view.h"
21 #include "grit/locale_settings.h"
22 #include "ui/base/accessibility/accessible_view_state.h"
23 #include "ui/base/resource/resource_bundle.h"
24 #include "ui/views/controls/button/label_button.h"
25 #include "ui/views/controls/label.h"
26 #include "ui/views/controls/link.h"
27 #include "ui/views/layout/grid_layout.h"
28 #include "ui/views/view.h"
29 #include "ui/views/widget/widget.h"
30
31 namespace {
32
33 // Layout constants.
34 const int kExtensionListPadding = 10;
35 const int kInsetBottomRight = 13;
36 const int kInsetLeft = 14;
37 const int kInsetTop = 9;
38 const int kHeadlineMessagePadding = 4;
39 const int kHeadlineRowPadding = 10;
40 const int kMessageBubblePadding = 11;
41
42 // How many extensions to show in the bubble (max).
43 const size_t kMaxExtensionsToShow = 7;
44
45 // How long to wait until showing the bubble (in seconds).
46 const int kBubbleAppearanceWaitTime = 5;
47
48 } // namespace
49
50 ////////////////////////////////////////////////////////////////////////////////
51 // ExtensionMessageBubbleView
52
53 namespace extensions {
54
55 ExtensionMessageBubbleView::ExtensionMessageBubbleView(
56 views::View* anchor_view,
57 ExtensionMessageBubbleController::Delegate* delegate)
58 : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
59 weak_factory_(this),
60 delegate_(delegate),
61 headline_(NULL),
62 learn_more_(NULL),
63 dismiss_button_(NULL),
64 link_clicked_(false),
65 action_taken_(false) {
66 DCHECK(anchor_view->GetWidget());
67 set_close_on_deactivate(false);
68 set_move_with_anchor(true);
69 set_close_on_esc(true);
70
71 // Compensate for built-in vertical padding in the anchor view's image.
72 set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
73 }
74
75 // static
76 void ExtensionMessageBubbleView::MaybeShow(
77 Browser* browser,
78 ToolbarView* toolbar_view,
79 views::View* anchor_view) {
80 #if defined(OS_WIN)
81 // The list of suspicious extensions takes priority over the dev mode bubble,
82 // since that needs to be shown as soon as we disable something. The dev mode
83 // bubble is not as time sensitive so we'll catch the dev mode extensions on
84 // the next startup/next window that opens. That way, we're not too spammy
85 // with the bubbles.
86 SuspiciousExtensionBubbleController* suspicious_extensions =
87 extensions::SuspiciousExtensionBubbleController::Get(
88 browser->profile());
89 if (suspicious_extensions->ShouldShow()) {
90 ExtensionMessageBubbleView* bubble_delegate =
91 new ExtensionMessageBubbleView(anchor_view, suspicious_extensions);
92 views::BubbleDelegateView::CreateBubble(bubble_delegate);
93 suspicious_extensions->Show(bubble_delegate);
94 return;
95 }
96
97 DevModeBubbleController* dev_mode_extensions =
98 extensions::DevModeBubbleController::Get(
99 browser->profile());
100 if (dev_mode_extensions->ShouldShow()) {
101 views::View* reference_view = NULL;
102 BrowserActionsContainer* container = toolbar_view->browser_actions();
103 if (container->animating())
104 return;
105
106 ExtensionService* service = extensions::ExtensionSystem::Get(
107 browser->profile())->extension_service();
108 extensions::ExtensionActionManager* extension_action_manager =
109 extensions::ExtensionActionManager::Get(browser->profile());
110
111 const ExtensionIdList extension_list =
112 dev_mode_extensions->GetExtensionIdList();
113 for (size_t i = 0; i < extension_list.size(); ++i) {
114 const Extension* extension =
115 service->GetExtensionById(extension_list[i], false);
116 if (!extension)
117 continue;
118 reference_view = container->GetBrowserActionView(
119 extension_action_manager->GetBrowserAction(*extension));
120 if (reference_view && reference_view->visible())
121 break; // Found a good candidate.
122 }
123 if (reference_view) {
124 // If we have a view, it means we found a browser action and we want to
125 // point to the chevron, not the hotdog menu.
126 if (!reference_view->visible())
127 reference_view = container->chevron(); // It's hidden, use the chevron.
128 }
129 if (reference_view && reference_view->visible())
130 anchor_view = reference_view; // Catch-all is the hotdog menu.
131
132 // Show the bubble.
133 ExtensionMessageBubbleView* bubble_delegate =
134 new ExtensionMessageBubbleView(anchor_view, dev_mode_extensions);
135 views::BubbleDelegateView::CreateBubble(bubble_delegate);
136 dev_mode_extensions->Show(bubble_delegate);
137 }
138 #endif
139 }
140
141 void ExtensionMessageBubbleView::OnActionButtonClicked(
142 const base::Closure& callback) {
143 action_callback_ = callback;
144 }
145
146 void ExtensionMessageBubbleView::OnDismissButtonClicked(
147 const base::Closure& callback) {
148 dismiss_callback_ = callback;
149 }
150
151 void ExtensionMessageBubbleView::OnLinkClicked(
152 const base::Closure& callback) {
153 link_callback_ = callback;
154 }
155
156 void ExtensionMessageBubbleView::Show() {
157 // Not showing the bubble right away (during startup) has a few benefits:
158 // We don't have to worry about focus being lost due to the Omnibox (or to
159 // other things that want focus at startup). This allows Esc to work to close
160 // the bubble and also solves the keyboard accessibility problem that comes
161 // with focus being lost (we don't have a good generic mechanism of injecting
162 // bubbles into the focus cycle). Another benefit of delaying the show is
163 // that fade-in works (the fade-in isn't apparent if the the bubble appears at
164 // startup).
165 base::MessageLoop::current()->PostDelayedTask(
166 FROM_HERE,
167 base::Bind(&ExtensionMessageBubbleView::ShowBubble,
168 weak_factory_.GetWeakPtr()),
169 base::TimeDelta::FromSeconds(kBubbleAppearanceWaitTime));
170 }
171
172 void ExtensionMessageBubbleView::OnWidgetDestroying(views::Widget* widget) {
173 // To catch Esc, we monitor destroy message. Unless the link has been clicked,
174 // we assume Dismiss was the action taken.
175 if (!link_clicked_ && !action_taken_)
176 dismiss_callback_.Run();
177 }
178
179 ////////////////////////////////////////////////////////////////////////////////
180 // ExtensionMessageBubbleView - private.
181
182 ExtensionMessageBubbleView::~ExtensionMessageBubbleView() {
183 }
184
185 void ExtensionMessageBubbleView::ShowBubble() {
186 StartFade(true);
187 }
188
189 void ExtensionMessageBubbleView::Init() {
190 ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
191
192 views::GridLayout* layout = views::GridLayout::CreatePanel(this);
193 layout->SetInsets(kInsetTop, kInsetLeft,
194 kInsetBottomRight, kInsetBottomRight);
195 SetLayoutManager(layout);
196
197 const int headline_column_set_id = 0;
198 views::ColumnSet* top_columns = layout->AddColumnSet(headline_column_set_id);
199 top_columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
200 0, views::GridLayout::USE_PREF, 0, 0);
201 top_columns->AddPaddingColumn(1, 0);
202 layout->StartRow(0, headline_column_set_id);
203
204 headline_ = new views::Label();
205 headline_->SetFont(rb.GetFont(ui::ResourceBundle::MediumFont));
206 headline_->SetText(delegate_->GetTitle());
207 layout->AddView(headline_);
208
209 layout->AddPaddingRow(0, kHeadlineRowPadding);
210
211 const int text_column_set_id = 1;
212 views::ColumnSet* upper_columns = layout->AddColumnSet(text_column_set_id);
213 upper_columns->AddColumn(
214 views::GridLayout::LEADING, views::GridLayout::LEADING,
215 0, views::GridLayout::USE_PREF, 0, 0);
216 layout->StartRow(0, text_column_set_id);
217
218 views::Label* message = new views::Label();
219 message->SetMultiLine(true);
220 message->SetHorizontalAlignment(gfx::ALIGN_LEFT);
221 message->SetText(delegate_->GetMessageBody());
222 message->SizeToFit(views::Widget::GetLocalizedContentsWidth(
223 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
224 layout->AddView(message);
225
226 if (delegate_->ShouldShowExtensionList()) {
227 const int extension_list_column_set_id = 2;
228 views::ColumnSet* middle_columns =
229 layout->AddColumnSet(extension_list_column_set_id);
230 middle_columns->AddPaddingColumn(0, kExtensionListPadding);
231 middle_columns->AddColumn(
232 views::GridLayout::LEADING, views::GridLayout::CENTER,
233 0, views::GridLayout::USE_PREF, 0, 0);
234
235 layout->StartRowWithPadding(0, extension_list_column_set_id,
236 0, kHeadlineMessagePadding);
237 views::Label* extensions = new views::Label();
238 extensions->SetMultiLine(true);
239 extensions->SetHorizontalAlignment(gfx::ALIGN_LEFT);
240
241 std::vector<string16> extension_list;
242 char16 bullet_point = 0x2022;
243
244 std::vector<string16> suspicious = delegate_->GetExtensions();
245 size_t i = 0;
246 for (; i < suspicious.size() && i < kMaxExtensionsToShow; ++i) {
247 // Add each extension with bullet point.
248 extension_list.push_back(
249 bullet_point + ASCIIToUTF16(" ") + suspicious[i]);
250 }
251
252 if (i > kMaxExtensionsToShow) {
253 string16 difference = base::IntToString16(i - kMaxExtensionsToShow);
254 extension_list.push_back(bullet_point + ASCIIToUTF16(" ") +
255 delegate_->GetOverflowText(difference));
256 }
257
258 extensions->SetText(JoinString(extension_list, ASCIIToUTF16("\n")));
259 extensions->SizeToFit(views::Widget::GetLocalizedContentsWidth(
260 IDS_EXTENSION_WIPEOUT_BUBBLE_WIDTH_CHARS));
261 layout->AddView(extensions);
262 }
263
264 string16 action_button = delegate_->GetActionButtonLabel();
265
266 const int action_row_column_set_id = 3;
267 views::ColumnSet* bottom_columns =
268 layout->AddColumnSet(action_row_column_set_id);
269 bottom_columns->AddColumn(views::GridLayout::LEADING,
270 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
271 bottom_columns->AddPaddingColumn(1, 0);
272 bottom_columns->AddColumn(views::GridLayout::TRAILING,
273 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
274 if (!action_button.empty()) {
275 bottom_columns->AddColumn(views::GridLayout::TRAILING,
276 views::GridLayout::CENTER, 0, views::GridLayout::USE_PREF, 0, 0);
277 }
278 layout->StartRowWithPadding(0, action_row_column_set_id,
279 0, kMessageBubblePadding);
280
281 learn_more_ = new views::Link(delegate_->GetLearnMoreLabel());
282 learn_more_->set_listener(this);
283 layout->AddView(learn_more_);
284
285 if (!action_button.empty()) {
286 action_button_ = new views::LabelButton(this, action_button.c_str());
287 action_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
288 layout->AddView(action_button_);
289 }
290
291 dismiss_button_ = new views::LabelButton(this,
292 delegate_->GetDismissButtonLabel());
293 dismiss_button_->SetStyle(views::Button::STYLE_NATIVE_TEXTBUTTON);
294 layout->AddView(dismiss_button_);
295 }
296
297 void ExtensionMessageBubbleView::ButtonPressed(views::Button* sender,
298 const ui::Event& event) {
299 if (sender == action_button_) {
300 action_taken_ = true;
301 action_callback_.Run();
302 } else {
303 DCHECK_EQ(dismiss_button_, sender);
304 }
305 GetWidget()->Close();
306 }
307
308 void ExtensionMessageBubbleView::LinkClicked(views::Link* source,
309 int event_flags) {
310 DCHECK_EQ(learn_more_, source);
311 link_clicked_ = true;
312 link_callback_.Run();
313 GetWidget()->Close();
314 }
315
316 void ExtensionMessageBubbleView::GetAccessibleState(
317 ui::AccessibleViewState* state) {
318 state->role = ui::AccessibilityTypes::ROLE_ALERT;
319 }
320
321 void ExtensionMessageBubbleView::ViewHierarchyChanged(
322 const ViewHierarchyChangedDetails& details) {
323 if (details.is_add && details.child == this)
324 NotifyAccessibilityEvent(ui::AccessibilityTypes::EVENT_ALERT, true);
325 }
326
327 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698