Issue 11415287: noSuchMethod generated for super calls

Issue 11415287: noSuchMethod generated for super calls (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ahe, ngeoffray

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

noSuchMethod generated for super calls Committed: https://code.google.com/p/dart/source/detail?r=15976

Patch Set 3 : Updated cf. comments. #

Patch Set 4 : Rebased #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -24 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1 2	1 chunk	+1 line, -9 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2	2 chunks	+53 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tests/language/super_call4_test.dart	View		2 chunks	+44 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11415287/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11415287/diff/1/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode3045 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3045: compiler.enqueuer.codegen.registerDynamicInvocation(name, selector); Why do you need this? Because ...

8 years ago (2012-12-06 22:46:09 UTC) #2

Johnni Winther

8 years ago (2012-12-11 14:26:40 UTC) #3

https://codereview.chromium.org/11415287/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11415287/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3045:
compiler.enqueuer.codegen.registerDynamicInvocation(name, selector);
On 2012/12/06 22:46:09, ngeoffray wrote:
> Why do you need this? Because you're creating an invocation mirror? What if
the
> invocation mirror is not being used? Wouldn't that lead to compiling unused
> methods?
> 
> If I'm right, I think you can avoid it by just checking that the super class
> implements noSuchMethod.

Removed.

Expand Messages | Collapse Messages