Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 11415266: Extract a delegate interface from c/b/input_method to permit decoupling from c/b. (Closed)

Created:
8 years ago by erikwright (departed)
Modified:
8 years ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, Jói
Visibility:
Public.

Description

Extract a delegate interface from c/b/chromeos/input_method to permit decoupling from c/b. BUG=164375 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172140

Patch Set 1 #

Patch Set 2 : Add mock_input_method_delegate to gypi file. #

Patch Set 3 : Sync. #

Patch Set 4 : Remove redundant gypi entries. #

Total comments: 1

Patch Set 5 : Class comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+559 lines, -468 lines) Patch
M chrome/browser/chromeos/input_method/browser_state_monitor.h View 2 chunks +8 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor.cc View 3 chunks +8 lines, -55 lines 0 comments Download
M chrome/browser/chromeos/input_method/browser_state_monitor_unittest.cc View 1 2 3 chunks +189 lines, -287 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_delegate.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_delegate_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/input_method_delegate_impl.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 4 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 5 chunks +17 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 9 chunks +20 lines, -51 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 7 chunks +10 lines, -13 lines 0 comments Download
A chrome/browser/chromeos/input_method/mock_input_method_delegate.h View 1 2 3 4 1 chunk +68 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/input_method/mock_input_method_delegate.cc View 1 chunk +40 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
erikwright (departed)
zork@: PTAL. With this change, the input_method implementation is nearly completely decoupled from chrome/browser. input_method_delegate_impl ...
8 years ago (2012-12-04 16:46:29 UTC) #1
Zachary Kuznia
nona@, please have a look, too. Looks generally good, please attach it to a bug.
8 years ago (2012-12-05 07:47:53 UTC) #2
erikwright (departed)
nona@: ping On 2012/12/05 07:47:53, Zachary Kuznia wrote: > nona@, please have a look, too. ...
8 years ago (2012-12-07 16:23:41 UTC) #3
Seigo Nonaka
lgtm Lgtm, sorry for late reply. https://codereview.chromium.org/11415266/diff/19007/chrome/browser/chromeos/input_method/mock_input_method_delegate.h File chrome/browser/chromeos/input_method/mock_input_method_delegate.h (right): https://codereview.chromium.org/11415266/diff/19007/chrome/browser/chromeos/input_method/mock_input_method_delegate.h#newcode24 chrome/browser/chromeos/input_method/mock_input_method_delegate.h:24: virtual void SetUserInputMethod(const ...
8 years ago (2012-12-08 08:37:58 UTC) #4
erikwright (departed)
jochen: PTAL for c/*.gypi and updated API name in c/b/ui/... .
8 years ago (2012-12-10 14:50:18 UTC) #5
jochen (gone - plz use gerrit)
lgtm
8 years ago (2012-12-10 14:52:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/11415266/25001
8 years ago (2012-12-10 14:55:10 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-10 22:03:46 UTC) #8
Message was sent while issue was closed.
Change committed as 172140

Powered by Google App Engine
This is Rietveld 408576698