Extract a delegate interface from c/b/input_method to permit decoupling from c/b.

chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/input_method_manager_impl.h"
 
 #include <algorithm>
 
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/chromeos/input_method/mock_candidate_window_controller.h"
 #include "chrome/browser/chromeos/input_method/mock_ibus_controller.h"
+#include "chrome/browser/chromeos/input_method/mock_input_method_delegate.h"
 #include "chrome/browser/chromeos/input_method/mock_xkeyboard.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 
 namespace chromeos {
 
 extern const char* kExtensionImePrefix;
 
 namespace input_method {
 namespace {
 
 class InputMethodManagerImplTest :  public testing::Test {
  public:
   InputMethodManagerImplTest()
-      : controller_(NULL),
-        candidate_window_controller_(NULL) {
+      : delegate_(NULL),
+        controller_(NULL),
+        candidate_window_controller_(NULL),
+        xkeyboard_(NULL) {
   }
   virtual ~InputMethodManagerImplTest() {}
 
-  virtual void SetUp() {
-    manager_.reset(InputMethodManagerImpl::GetInstanceForTesting());
+  virtual void SetUp() OVERRIDE {
+    delegate_ = new MockInputMethodDelegate();
+    manager_.reset(new InputMethodManagerImpl(
+        scoped_ptr<InputMethodDelegate>(delegate_)));
     controller_ = new MockIBusController;
     manager_->SetIBusControllerForTesting(controller_);
     candidate_window_controller_ = new MockCandidateWindowController;
     manager_->SetCandidateWindowControllerForTesting(
         candidate_window_controller_);
     xkeyboard_ = new MockXKeyboard;
     manager_->SetXKeyboardForTesting(xkeyboard_);
   }
 
-  virtual void TearDown() {
-    manager_.reset();
+  virtual void TearDown() OVERRIDE {
+    delegate_ = NULL;
     controller_ = NULL;
     candidate_window_controller_ = NULL;
     xkeyboard_ = NULL;
-  }
-
-  void SetHardwareKeyboardLayout(const std::string& input_method_id) {
-    manager_->GetInputMethodUtil()->SetHardwareInputMethodIdForTesting(
-        input_method_id);
+    manager_.reset();
   }
 
  protected:
   scoped_ptr<InputMethodManagerImpl> manager_;
+  MockInputMethodDelegate* delegate_;
   MockIBusController* controller_;
   MockCandidateWindowController* candidate_window_controller_;
   MockXKeyboard* xkeyboard_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(InputMethodManagerImplTest);
 };
 
 class TestObserver : public InputMethodManager::Observer {
  public:
@@ skipping 45 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(TestCandidateWindowObserver);
 };
 
 }  // namespace
 
 TEST_F(InputMethodManagerImplTest, TestGetXKeyboard) {
   EXPECT_TRUE(manager_->GetXKeyboard());
   EXPECT_EQ(xkeyboard_, manager_->GetXKeyboard());
 }
 
-TEST_F(InputMethodManagerImplTest, TestGetInputMethodUtil) {
-  EXPECT_TRUE(manager_->GetInputMethodUtil());
-  SetHardwareKeyboardLayout("xkb:fr::fra");  // check this does not crash.
-}
-
 TEST_F(InputMethodManagerImplTest, TestCandidateWindowObserver) {
   TestCandidateWindowObserver observer;
   candidate_window_controller_->NotifyCandidateWindowOpened();  // nop
   candidate_window_controller_->NotifyCandidateWindowClosed();  // nop
   manager_->AddCandidateWindowObserver(&observer);
   candidate_window_controller_->NotifyCandidateWindowOpened();
   EXPECT_EQ(1, observer.candidate_window_opened_count_);
   candidate_window_controller_->NotifyCandidateWindowClosed();
   EXPECT_EQ(1, observer.candidate_window_closed_count_);
   candidate_window_controller_->NotifyCandidateWindowOpened();
@@ skipping 76 matching lines @@
 
   // For http://crbug.com/19655#c11 - (5)
   // The hardware keyboard layout "xkb:us::eng" is always active, hence 2U.
   manager_->EnableLayouts("ja", "");  // Japanese
   EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());
   EXPECT_EQ(0, controller_->start_count_);
 }
 
 TEST_F(InputMethodManagerImplTest, TestEnableLayoutsNonUsHardwareKeyboard) {
   // The physical layout is French.
-  SetHardwareKeyboardLayout("xkb:fr::fra");
+  delegate_->set_hardware_keyboard_layout("xkb:fr::fra");
   manager_->EnableLayouts("en-US", "");
   EXPECT_EQ(6U, manager_->GetNumActiveInputMethods());  // 5 + French
   // The physical layout is Japanese.
-  SetHardwareKeyboardLayout("xkb:jp::jpn");
+  delegate_->set_hardware_keyboard_layout("xkb:jp::jpn");
   manager_->EnableLayouts("ja", "");
   // "xkb:us::eng" is not needed, hence 1.
   EXPECT_EQ(1U, manager_->GetNumActiveInputMethods());
 }
 
 TEST_F(InputMethodManagerImplTest, TestActiveInputMethods) {
   manager_->EnableLayouts("ko", "");  // Korean
   EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());
   scoped_ptr<InputMethodDescriptors> methods(
       manager_->GetActiveInputMethods());
@@ skipping 746 matching lines @@
   EXPECT_EQ("mozc", controller_->change_input_method_id_);
   EXPECT_EQ(1, controller_->reset_count_);
   manager_->ChangeInputMethod("xkb:us::eng");
   EXPECT_EQ(2, controller_->change_input_method_count_);
   EXPECT_EQ("mozc", controller_->change_input_method_id_);
   EXPECT_EQ(1, controller_->reset_count_);
 }
 
 }  // namespace input_method
 }  // namespace chromeos