Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3602)

Unified Diff: chrome/browser/ui/webui/options/chromeos/language_options_util.h

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fixes Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/language_options_util.h
diff --git a/chrome/browser/ui/webui/options/chromeos/language_options_util.h b/chrome/browser/ui/webui/options/chromeos/language_options_util.h
index 74e5617271783fc1e5caf5850aaeef4c00b6ad50..34f45418d72df8c487ebe02c989e657e8df5d43c 100644
--- a/chrome/browser/ui/webui/options/chromeos/language_options_util.h
+++ b/chrome/browser/ui/webui/options/chromeos/language_options_util.h
@@ -49,8 +49,8 @@ std::string GetTemplateDataMaxName(const T& preference, const char* prefix) {
// Creates a Value object from the given value. Here we use function
// overloading to handle string and integer preferences in
// CreateMultipleChoiceList.
-Value* CreateValue(const char* in_value);
-Value* CreateValue(int in_value);
+base::Value* CreateValue(const char* in_value);
+base::Value* CreateValue(int in_value);
// Creates a multiple choice list from the given preference.
template <typename T>
@@ -71,7 +71,7 @@ base::ListValue* CreateMultipleChoiceList(
base::ListValue* option = new base::ListValue();
option->Append(CreateValue(
preference.values_and_ids[i].ibus_config_value));
- option->Append(base::Value::CreateStringValue(l10n_util::GetStringUTF16(
+ option->Append(new base::StringValue(l10n_util::GetStringUTF16(
preference.values_and_ids[i].item_message_id)));
list_value->Append(option);
}

Powered by Google App Engine
This is Rietveld 408576698