chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc - Issue 11415226: webui/options: Do not use Value::CreateStringValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixes Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc ('K') | « chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/language_options_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc b/chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

index 3a0274afce3d6b08ccb6a7c19872e7540fec415b..4000291ff0efc577bf6b151c0d079799f2131205 100644

--- a/chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/language_hangul_handler.cc

@@ -36,9 +36,9 @@ ListValue* LanguageHangulHandler::GetKeyboardLayoutList() {

ListValue* keyboard_layout_list = new ListValue();

for (size_t i = 0; i < language_prefs::kNumHangulKeyboardNameIDPairs; ++i) {

ListValue* option = new ListValue();

- option->Append(Value::CreateStringValue(

+ option->Append(new base::StringValue(

language_prefs::kHangulKeyboardNameIDPairs[i].keyboard_id));

- option->Append(Value::CreateStringValue(l10n_util::GetStringUTF16(

+ option->Append(new base::StringValue(l10n_util::GetStringUTF16(

language_prefs::kHangulKeyboardNameIDPairs[i].message_id)));

keyboard_layout_list->Append(option);

}