chrome/browser/ui/webui/options/options_sync_setup_handler.cc - Issue 11415226: webui/options: Do not use Value::CreateStringValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/options_sync_setup_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Evan review Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/options_sync_setup_handler.cc

diff --git a/chrome/browser/ui/webui/options/options_sync_setup_handler.cc b/chrome/browser/ui/webui/options/options_sync_setup_handler.cc

index 32c4acc2e85063de61b590ed916b5fb8c7f7a20e..f1b43f2c9d4870ae0336c955d77206094c354745 100644

--- a/chrome/browser/ui/webui/options/options_sync_setup_handler.cc

+++ b/chrome/browser/ui/webui/options/options_sync_setup_handler.cc

@@ -20,8 +20,8 @@ OptionsSyncSetupHandler::~OptionsSyncSetupHandler() {

void OptionsSyncSetupHandler::ShowSetupUI() {

// Show the Sync Setup page.

- scoped_ptr<Value> page(Value::CreateStringValue("syncSetup"));

- web_ui()->CallJavascriptFunction("OptionsPage.navigateToPage", *page);

+ web_ui()->CallJavascriptFunction("OptionsPage.navigateToPage",

+ base::StringValue("syncSetup"));

}

} // namespace options