webui/options: Do not use Value::CreateStringValue.

chrome/browser/ui/webui/options/content_settings_handler.cc

Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 5e217c3e29a3c8725b5428ee61c53c0877b1fcf4..eb3d8700bdda2dde6a1741f9cc428a80494cbec5 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -1246,17 +1246,17 @@ void ContentSettingsHandler::CheckExceptionPatternValidity(
     is_valid = pattern.IsValid();
   }
 
-  scoped_ptr<Value> type_value(Value::CreateStringValue(type_string));
-  scoped_ptr<Value> mode_value(Value::CreateStringValue(mode_string));
-  scoped_ptr<Value> pattern_value(Value::CreateStringValue(pattern_string));
+  scoped_ptr<Value> type_value(new base::StringValue(type_string));

[Evan Stade, 2012/11/30 22:47:00]

why do these still exist

[tfarina, 2012/11/30 23:07:31]

Done.

+  scoped_ptr<Value> mode_value(new base::StringValue(mode_string));
+  scoped_ptr<Value> pattern_value(new base::StringValue(pattern_string));
   scoped_ptr<Value> valid_value(Value::CreateBooleanValue(is_valid));
 
   web_ui()->CallJavascriptFunction(
       "ContentSettings.patternValidityCheckComplete",
-      *type_value.get(),
-      *mode_value.get(),
-      *pattern_value.get(),
-      *valid_value.get());
+      base::StringValue(type_string),
+      base::StringValue(mode_string),
+      base::StringValue(pattern_string),
+      base::FundamentalValue(is_valid));
 }
 
 // static