Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5462)

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Evan review Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/sync/one_click_signin_helper.cc
diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc
index ac9597eddb354b76837c66f00a1a2221ba6660c6..0d8cab3b3c22fcd03ed754857bfb7d5904db9327 100644
--- a/chrome/browser/ui/sync/one_click_signin_helper.cc
+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc
@@ -433,9 +433,8 @@ bool OneClickSigninHelper::CanOffer(content::WebContents* web_contents,
const ListValue* rejected_emails = profile->GetPrefs()->GetList(
prefs::kReverseAutologinRejectedEmailList);
if (!rejected_emails->empty()) {
- const scoped_ptr<Value> email_value(new base::StringValue(email));
base::ListValue::const_iterator iter = rejected_emails->Find(
- *email_value);
+ base::StringValue(email));
if (iter != rejected_emails->end())
return false;
}

Powered by Google App Engine
This is Rietveld 408576698