Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: chrome/browser/ui/webui/options/handler_options_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/handler_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/handler_options_handler.cc b/chrome/browser/ui/webui/options/handler_options_handler.cc
index 551b3fb5433768bb57f0a0e300dfa29fac7615c0..b40ab9ae536acf71efaac67ff3d7165bc81a0c13 100644
--- a/chrome/browser/ui/webui/options/handler_options_handler.cc
+++ b/chrome/browser/ui/webui/options/handler_options_handler.cc
@@ -92,9 +92,9 @@ static void GetHandlersAsListValue(
ProtocolHandlerRegistry::ProtocolHandlerList::const_iterator handler;
for (handler = handlers.begin(); handler != handlers.end(); ++handler) {
ListValue* handlerValue = new ListValue();
- handlerValue->Append(Value::CreateStringValue(handler->protocol()));
- handlerValue->Append(Value::CreateStringValue(handler->url().spec()));
- handlerValue->Append(Value::CreateStringValue(handler->title()));
+ handlerValue->Append(new base::StringValue(handler->protocol()));
+ handlerValue->Append(new base::StringValue(handler->url().spec()));
+ handlerValue->Append(new base::StringValue(handler->title()));
handler_list->Append(handlerValue);
}
}

Powered by Google App Engine
This is Rietveld 408576698