webui/options: Do not use Value::CreateStringValue.

chrome/browser/ui/webui/options/content_settings_handler.cc

Index: chrome/browser/ui/webui/options/content_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc
index 5e217c3e29a3c8725b5428ee61c53c0877b1fcf4..5d1ec8e94d93a2ca4c55d91e058803d4f7eda7fb 100644
--- a/chrome/browser/ui/webui/options/content_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc
@@ -1246,9 +1246,9 @@ void ContentSettingsHandler::CheckExceptionPatternValidity(
     is_valid = pattern.IsValid();
   }
 
-  scoped_ptr<Value> type_value(Value::CreateStringValue(type_string));
-  scoped_ptr<Value> mode_value(Value::CreateStringValue(mode_string));
-  scoped_ptr<Value> pattern_value(Value::CreateStringValue(pattern_string));
+  scoped_ptr<Value> type_value(new base::StringValue(type_string));

[Evan Stade, 2012/11/30 20:15:56]

these do not need to be scoped pointers. You can just pass them directly into
CallJavascriptFunction (without 'new')

[tfarina, 2012/11/30 22:41:08]

Done.

+  scoped_ptr<Value> mode_value(new base::StringValue(mode_string));
+  scoped_ptr<Value> pattern_value(new base::StringValue(pattern_string));
   scoped_ptr<Value> valid_value(Value::CreateBooleanValue(is_valid));
 
   web_ui()->CallJavascriptFunction(