Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4972)

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc
index 3a07265d5fd7b5e633c366e0b0bf729267373211..bd1d5edb6fe7ed32759ee96619ba7eb75d5875e7 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options/core_options_handler.cc
@@ -285,7 +285,7 @@ void CoreOptionsHandler::DispatchPrefChangeNotification(
PreferenceCallbackMap::const_iterator> range =
pref_callback_map_.equal_range(name);
ListValue result_value;
- result_value.Append(base::Value::CreateStringValue(name.c_str()));
+ result_value.Append(new base::StringValue(name.c_str()));
result_value.Append(value.release());
for (PreferenceCallbackMap::const_iterator iter = range.first;
iter != range.second; ++iter) {
@@ -477,7 +477,7 @@ void CoreOptionsHandler::HandleSetPref(const ListValue* args, PrefType type) {
std::string original;
CHECK(value->GetAsString(&original));
GURL fixed = URLFixerUpper::FixupURL(original, std::string());
- temp_value.reset(base::Value::CreateStringValue(fixed.spec()));
+ temp_value.reset(new base::StringValue(fixed.spec()));
value = temp_value.get();
break;
}

Powered by Google App Engine
This is Rietveld 408576698