Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/webui/options/cookies_view_handler.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/cookies_view_handler.cc
diff --git a/chrome/browser/ui/webui/options/cookies_view_handler.cc b/chrome/browser/ui/webui/options/cookies_view_handler.cc
index 4bb075c027d5b3a91734566e6293d5ce36a14b14..19d622ef43f07a543a80dea0837b4fb0abfe94f4 100644
--- a/chrome/browser/ui/webui/options/cookies_view_handler.cc
+++ b/chrome/browser/ui/webui/options/cookies_view_handler.cc
@@ -152,8 +152,7 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
ListValue args;
args.Append(parent == tree_model->GetRoot() ?
Value::CreateNullValue() :
- Value::CreateStringValue(
- model_util_->GetTreeNodeId(parent_node)));
+ new base::StringValue(model_util_->GetTreeNodeId(parent_node)));
args.Append(Value::CreateIntegerValue(start));
args.Append(children);
web_ui()->CallJavascriptFunction(
@@ -173,7 +172,7 @@ void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
ListValue args;
args.Append(parent == tree_model->GetRoot() ?
Value::CreateNullValue() :
- Value::CreateStringValue(model_util_->GetTreeNodeId(
+ new base::StringValue(model_util_->GetTreeNodeId(
tree_model->AsNode(parent))));
args.Append(Value::CreateIntegerValue(start));
args.Append(Value::CreateIntegerValue(count));
@@ -309,7 +308,7 @@ void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
ListValue args;
args.Append(parent == GetTreeModel()->GetRoot() ?
Value::CreateNullValue() :
- Value::CreateStringValue(model_util_->GetTreeNodeId(parent)));
+ new base::StringValue(model_util_->GetTreeNodeId(parent)));
args.Append(children);
web_ui()->CallJavascriptFunction(

Powered by Google App Engine
This is Rietveld 408576698