Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5763)

Unified Diff: chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc

Issue 11415226: webui/options: Do not use Value::CreateStringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc b/chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc
index f2ed2c3ef4b18149fbb3f9e5404bd30d9ee604c1..ef6d809f40cf64eec6d3cb339f406a3dcdde070d 100644
--- a/chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc
+++ b/chrome/browser/ui/webui/options/chromeos/timezone_options_util.cc
@@ -132,9 +132,9 @@ scoped_ptr<base::ListValue> GetTimezoneList() {
iter != timezones.end(); ++iter) {
const icu::TimeZone* timezone = *iter;
base::ListValue* option = new base::ListValue();
- option->Append(Value::CreateStringValue(
+ option->Append(new base::StringValue(
chromeos::system::TimezoneSettings::GetTimezoneID(*timezone)));
- option->Append(Value::CreateStringValue(GetTimezoneName(*timezone)));
+ option->Append(new base::StringValue(GetTimezoneName(*timezone)));
timezoneList->Append(option);
}
return timezoneList.Pass();

Powered by Google App Engine
This is Rietveld 408576698