Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: chrome/browser/autofill/field_types.h

Issue 11415221: Add support for autofilling radio buttons and checkboxes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: addressed review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/field_types.h
diff --git a/chrome/browser/autofill/field_types.h b/chrome/browser/autofill/field_types.h
index 832b94a0cb0a47999026379aad85cdb66902e771..6091ec913aa95ee4b0fb6be94a77dc960c133859 100644
--- a/chrome/browser/autofill/field_types.h
+++ b/chrome/browser/autofill/field_types.h
@@ -6,6 +6,7 @@
#define CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_
#include <set>
+#include <string>
// NOTE: This list MUST not be modified. The server aggregates and stores these
// types over several versions, so we must remain fully compatible with the
@@ -77,11 +78,15 @@ enum AutofillFieldType {
COMPANY_NAME = 60,
+ // Generic type whose default value is known.
+ FIELD_WITH_DEFAULT_VALUE = 61,
Ilya Sherman 2012/12/01 00:54:12 Has the server-side change adding this field type
Ilya Sherman 2012/12/01 00:54:12 You should update the if-stmt in AutofillField::se
Raman Kakilate 2012/12/06 01:54:05 Yes, they are in.
Raman Kakilate 2012/12/06 01:54:05 Done.
+
// No new types can be added.
- MAX_VALID_FIELD_TYPE = 61,
+ MAX_VALID_FIELD_TYPE = 62,
};
typedef std::set<AutofillFieldType> FieldTypeSet;
+typedef std::pair<AutofillFieldType, std::string> AutofillFieldInfo;
Ilya Sherman 2012/12/01 00:54:12 Please don't add this typedef here. Spell out thi
Raman Kakilate 2012/12/06 01:54:05 Removed and created a struct for AutofillServerFie
#endif // CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_

Powered by Google App Engine
This is Rietveld 408576698