Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/autofill/field_types.h

Issue 11415221: Add support for autofilling radio buttons and checkboxes. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: addressed review comments Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_ 5 #ifndef CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_
6 #define CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_ 6 #define CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_
7 7
8 #include <set> 8 #include <set>
9 #include <string>
9 10
10 // NOTE: This list MUST not be modified. The server aggregates and stores these 11 // NOTE: This list MUST not be modified. The server aggregates and stores these
11 // types over several versions, so we must remain fully compatible with the 12 // types over several versions, so we must remain fully compatible with the
12 // Autofill server, which is itself backward-compatible. The list must be kept 13 // Autofill server, which is itself backward-compatible. The list must be kept
13 // up to date with the Autofill server list. 14 // up to date with the Autofill server list.
14 // 15 //
15 // This is the list of all valid field types. 16 // This is the list of all valid field types.
16 enum AutofillFieldType { 17 enum AutofillFieldType {
17 // Server indication that it has no data for the requested field. 18 // Server indication that it has no data for the requested field.
18 NO_SERVER_DATA = 0, 19 NO_SERVER_DATA = 0,
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 CREDIT_CARD_EXP_MONTH = 53, 71 CREDIT_CARD_EXP_MONTH = 53,
71 CREDIT_CARD_EXP_2_DIGIT_YEAR = 54, 72 CREDIT_CARD_EXP_2_DIGIT_YEAR = 54,
72 CREDIT_CARD_EXP_4_DIGIT_YEAR = 55, 73 CREDIT_CARD_EXP_4_DIGIT_YEAR = 55,
73 CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR = 56, 74 CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR = 56,
74 CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR = 57, 75 CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR = 57,
75 CREDIT_CARD_TYPE = 58, 76 CREDIT_CARD_TYPE = 58,
76 CREDIT_CARD_VERIFICATION_CODE = 59, 77 CREDIT_CARD_VERIFICATION_CODE = 59,
77 78
78 COMPANY_NAME = 60, 79 COMPANY_NAME = 60,
79 80
81 // Generic type whose default value is known.
82 FIELD_WITH_DEFAULT_VALUE = 61,
Ilya Sherman 2012/12/01 00:54:12 Has the server-side change adding this field type
Ilya Sherman 2012/12/01 00:54:12 You should update the if-stmt in AutofillField::se
Raman Kakilate 2012/12/06 01:54:05 Yes, they are in.
Raman Kakilate 2012/12/06 01:54:05 Done.
83
80 // No new types can be added. 84 // No new types can be added.
81 85
82 MAX_VALID_FIELD_TYPE = 61, 86 MAX_VALID_FIELD_TYPE = 62,
83 }; 87 };
84 88
85 typedef std::set<AutofillFieldType> FieldTypeSet; 89 typedef std::set<AutofillFieldType> FieldTypeSet;
90 typedef std::pair<AutofillFieldType, std::string> AutofillFieldInfo;
Ilya Sherman 2012/12/01 00:54:12 Please don't add this typedef here. Spell out thi
Raman Kakilate 2012/12/06 01:54:05 Removed and created a struct for AutofillServerFie
86 91
87 #endif // CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_ 92 #endif // CHROME_BROWSER_AUTOFILL_FIELD_TYPES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698