Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: third_party/cacheinvalidation/cacheinvalidation.gyp

Issue 11415141: Add guava and jsr-305 to third_party for Android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/guava/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cacheinvalidation/cacheinvalidation.gyp
diff --git a/third_party/cacheinvalidation/cacheinvalidation.gyp b/third_party/cacheinvalidation/cacheinvalidation.gyp
index 84aeb96e8b7463a96295f35b0a80ac9a2cb6392d..c722dc57e680329b54201c16560d912aba458dea 100644
--- a/third_party/cacheinvalidation/cacheinvalidation.gyp
+++ b/third_party/cacheinvalidation/cacheinvalidation.gyp
@@ -195,8 +195,8 @@
'type': 'none',
'dependencies': [
'../../third_party/android_tools/android_tools.gyp:android_gcm',
+ '../../third_party/guava/guava.gyp:guava_javalib',
'cacheinvalidation_aidl_javalib',
- 'cacheinvalidation_guava_javalib',
'cacheinvalidation_proto_java',
],
'variables': {
@@ -221,18 +221,6 @@
],
'includes': [ '../../build/java_aidl.gypi' ],
},
- # TODO(nyquist): Depend on guava from third_party/guava. See http://crbug.com/159873.
- {
- 'target_name': 'cacheinvalidation_guava_javalib',
- 'type' : 'none',
- 'all_dependent_settings': {
- 'variables': {
- 'input_jars_paths' : [
- 'src/example-app-build/libs/guava-13.0.1.jar',
- ],
- }
- }
- },
],
}],
],
« no previous file with comments | « no previous file | third_party/guava/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698