Chromium Code Reviews
Help | Chromium Project | Sign in
(730)

Issue 11415051: Revert r12990 and r12991 from trunk. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Michael Starzinger
Modified:
1 year, 5 months ago
Reviewers:
Jakob
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Revert r12990 and r12991 from trunk.

Revert "Clean-up refactoring to eliminate GetLocalElementKind."
Revert "Drastically reduce the number of created strings in d8."

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=13002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -234 lines) Lint Patch
M src/d8.cc View 24 chunks +88 lines, -113 lines 0 comments 0 errors Download
M src/objects.h View 2 chunks +20 lines, -3 lines 0 comments 0 errors Download
M src/objects.cc View 4 chunks +105 lines, -25 lines 0 comments 0 errors Download
M src/objects-inl.h View 1 chunk +0 lines, -4 lines 0 comments 0 errors Download
M src/runtime.cc View 3 chunks +218 lines, -87 lines 0 comments 0 errors Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M test/mjsunit/regress/regress-1692.js View 1 chunk +1 line, -1 line 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Michael Starzinger
1 year, 5 months ago #1
Jakob
1 year, 5 months ago #2
LGTM (reviewed version.cc, rubber-stamped the rest)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6