Issue 11415051: Revert r12990 and r12991 from trunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415051: Revert r12990 and r12991 from trunk. (Closed)

Created:
8 years, 1 month ago by Michael Starzinger

Modified:
8 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

Revert r12990 and r12991 from trunk. Revert "Clean-up refactoring to eliminate GetLocalElementKind." Revert "Drastically reduce the number of created strings in d8." R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13002

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+433 lines, -234 lines)			Patch
M	src/d8.cc	View	24 chunks	+88 lines, -113 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+20 lines, -3 lines	0 comments	Download
M	src/objects.cc	View	4 chunks	+105 lines, -25 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+218 lines, -87 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/regress/regress-1692.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Jakob Kummerow

8 years, 1 month ago (2012-11-19 15:36:33 UTC) #2

LGTM (reviewed version.cc, rubber-stamped the rest)