Relax assertions around context loss and program initialization. Higher level code will take care o…

Relax assertions around context loss and program initialization. Higher level code will take care of issuing repaints as necessary.

BUG=161571
TEST=GPUCrashTest.Kill in Debug mode on Windows


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168464

[Ken Russell (switch to Gerrit), 2012-11-17 00:29:19]

Please review. Thanks.

[nduca, 2012-11-17 17:02:50]

lgtm. As we discussed, there's a good chance you're gonna run into a few places
in the texture upload system [queries, etc] that assume that we get valid return
values from GL.

https://codereview.chromium.org/11415040/diff/1/cc/program_binding.h
File cc/program_binding.h (right):

https://codereview.chromium.org/11415040/diff/1/cc/program_binding.h#newcode56
cc/program_binding.h:56: if (IsContextLost(context))
Is this oen needed to sidestep a really hard case to handle, or is this just
sort of a "well, why we know we're screwed bother?"

[Ken Russell (switch to Gerrit), 2012-11-17 20:23:42]

Going to try CQ'ing this.

https://codereview.chromium.org/11415040/diff/1/cc/program_binding.h
File cc/program_binding.h (right):

https://codereview.chromium.org/11415040/diff/1/cc/program_binding.h#newcode56
cc/program_binding.h:56: if (IsContextLost(context))
On 2012/11/17 17:02:50, nduca wrote:
> Is this oen needed to sidestep a really hard case to handle, or is this just
> sort of a "well, why we know we're screwed bother?"

I actually didn't try without it -- seemed best to skip the later setup because
there's no error checking before setting m_initialized to true.

[commit-bot: I haz the power, 2012-11-17 20:23:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kbr@chromium.org/11415040/1

[commit-bot: I haz the power, 2012-11-17 22:24:48]

Change committed as 168464