Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1141503002: Revert of [Chromecast] Ignore interfaces not used to connect to internet. (Closed)

Created:
5 years, 7 months ago by gunsch
Modified:
5 years, 7 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Chromecast] Ignore interfaces not used to connect to internet. (patchset #1 id:1 of https://codereview.chromium.org/1137483004/) Reason for revert: broke the Android builds. Not sure how "cast_shell_android" passed, actually. Original issue's description: > [Chromecast] Ignore interfaces not used to connect to internet. > > Add NetworkChangeNotifierFactoryCast to create instance of > NetworkChangeNotifierLinux that ignores interfaces that will not be > used to connect to internet. > > BUG=469863 > R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org > > Committed: https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614 > Cr-Commit-Position: refs/heads/master@{#329319} TBR=byungchul@chromium.org,wzhong@chromium.org,derekjchow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=469863 Committed: https://crrev.com/4b40fb3b268414b5d6cbf2987a901287b6ddc6da Cr-Commit-Position: refs/heads/master@{#329348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -112 lines) Patch
M chromecast/browser/cast_browser_main_parts.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chromecast/chromecast.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
D chromecast/net/net_util_cast.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chromecast/net/net_util_cast.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D chromecast/net/network_change_notifier_factory_cast.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chromecast/net/network_change_notifier_factory_cast.cc View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gunsch
Created Revert of [Chromecast] Ignore interfaces not used to connect to internet.
5 years, 7 months ago (2015-05-12 04:20:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1141503002/1
5 years, 7 months ago (2015-05-12 04:21:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 04:22:32 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 04:23:22 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b40fb3b268414b5d6cbf2987a901287b6ddc6da
Cr-Commit-Position: refs/heads/master@{#329348}

Powered by Google App Engine
This is Rietveld 408576698