[Chromecast] Ignore interfaces not used to connect to internet.

[Chromecast] Ignore interfaces not used to connect to internet.

Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.

BUG=469863
R=gunsch@chromium.org,byungchul@chromium.org,wzhong@chromium.org

Committed: https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614
Cr-Commit-Position: refs/heads/master@{#329319}

[gunsch, 2015-05-11 22:02:13]

Some questions:

1) Will GetIgnoredInterfaces be called more than once? If not, can we inline
most of that code to the NetworkChangeNotifierFactoryCast file?

2) Are there any potentially negative side effects to creating CastSysInfo more
than once?

[derekjchow1, 2015-05-11 22:09:04]

On 2015/05/11 22:02:13, gunsch wrote:
> Some questions:
> 
> 1) Will GetIgnoredInterfaces be called more than once? If not, can we inline
> most of that code to the NetworkChangeNotifierFactoryCast file?

Yes it will be called in internal code (if you take a look at my matching
internal CL, you'll actually see a TODO removed =)).

> 2) Are there any potentially negative side effects to creating CastSysInfo
more
> than once?

Possibly performance (if CastSysInfo is not implemented efficiently). However,
in the CastSysInfo header file, it explicitly mentions that the class can be
instantiated multiple times at any point the the start up process.

[gunsch, 2015-05-11 22:13:58]

Thanks for the answers. In that case, lgtm here, but get Byungchul's approval as
well.

[byungchul, 2015-05-12 00:55:52]

https://codereview.chromium.org/1137483004/diff/1/chromecast/net/net_util_cas...
File chromecast/net/net_util_cast.cc (right):

https://codereview.chromium.org/1137483004/diff/1/chromecast/net/net_util_cas...
chromecast/net/net_util_cast.cc:15: base::hash_set<std::string>
GetIgnoredInterfaces() {
Any reason why it doesn't get sys_info as a parameter? Though I saw the answer
about Jesse's question, it will show that this function depends on sys_info
clearly.

[byungchul, 2015-05-12 01:13:23]

lgtm

https://codereview.chromium.org/1137483004/diff/1/chromecast/net/net_util_cas...
File chromecast/net/net_util_cast.cc (right):

https://codereview.chromium.org/1137483004/diff/1/chromecast/net/net_util_cas...
chromecast/net/net_util_cast.cc:15: base::hash_set<std::string>
GetIgnoredInterfaces() {
On 2015/05/12 00:55:52, byungchul wrote:
> Any reason why it doesn't get sys_info as a parameter? Though I saw the answer
> about Jesse's question, it will show that this function depends on sys_info
> clearly.

Never mind. I just saw the other CL adding ignored interface in NCNLinux.

[derekjchow1, 2015-05-12 01:19:51]

The CQ bit was checked by derekjchow@chromium.org

[commit-bot: I haz the power, 2015-05-12 01:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137483004/1

[commit-bot: I haz the power, 2015-05-12 02:13:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-05-12 02:14:11]

Patchset 1 (id:??) landed as
https://crrev.com/561d7adb5ec842c5e56ece4524d0e486691ca614
Cr-Commit-Position: refs/heads/master@{#329319}

[gunsch, 2015-05-12 04:20:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1141503002/ by gunsch@chromium.org.

The reason for reverting is: broke the Android builds. Not sure how
"cast_shell_android" passed, actually..