pkg/fixnum/lib/src/int32.dart - Issue 11415028: Remove NullPointerException.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/fixnum/lib/src/int32.dart

Issue 11415028: Remove NullPointerException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/fixnum/lib/src/int32.dart

diff --git a/pkg/fixnum/lib/src/int32.dart b/pkg/fixnum/lib/src/int32.dart

index 80f5f3c5166b42e92c76ef2032ea5a356fe4fa0c..ecec4b1167a341061ccb373890b3d758c1cc5518 100644

--- a/pkg/fixnum/lib/src/int32.dart

+++ b/pkg/fixnum/lib/src/int32.dart

@@ -142,7 +142,7 @@ class int32 implements intx {

// will be truncated.

int _convert(other) {

if (other == null) {

- throw new NullPointerException();

+ throw new ArgumentError("other is null");

} else if (other is intx) {

return other.toInt32()._i;

} else if (other is int) {

« no previous file with comments | « no previous file | pkg/fixnum/lib/src/int64.dart » ('j') | runtime/lib/object.cc » ('J')