Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: runtime/lib/object.cc

Issue 11415028: Remove NullPointerException. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/object.cc
diff --git a/runtime/lib/object.cc b/runtime/lib/object.cc
index 3d9ed92cea65aae79d7c3c1e83d9ce1b7f69ae41..f52dfd915749dc4243d106b50b7cc7ecb978d9b5 100644
--- a/runtime/lib/object.cc
+++ b/runtime/lib/object.cc
@@ -26,7 +26,7 @@ DEFINE_NATIVE_ENTRY(Object_noSuchMethod, 3) {
GrowableArray<const Object*> args;
args.Add(&function_name);
args.Add(&func_args);
- Exceptions::ThrowByType(Exceptions::kNullPointer, args);
+ Exceptions::ThrowByType(Exceptions::kNullThrown, args);
regis 2012/11/19 19:45:31 We called a method on null. Is NullThrown the righ
Lasse Reichstein Nielsen 2012/11/20 09:21:11 Noooo, kNullThrown is wrong! We should just fall t
}
const Object& null_object = Object::Handle(Object::null());
GrowableArray<const Object*> dart_arguments(3);
« no previous file with comments | « runtime/lib/expando_patch.dart ('k') | runtime/lib/regexp.cc » ('j') | runtime/lib/regexp.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698