A11y: Introduce High Contrast Mode and Screen Magnifier to ubar tray.

A11y: Introduce High Contrast Mode and Screen Magnifier to ubar tray.

This patch add a sub-menu to set accessibility feature (spoken feedback, high-contrast and screen magnifier) under accessibility menu. 

The design is at http://crbug.com/158281. 

BUG=160689, 158307
TEST=manual

TBR=nkostylev@chromium.org, jhawkins@chromium.org
# TBRing for just rename changes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170180

[yoshiki, 2012-11-16 06:46:58]

zork: could you take a first look at this CL, instead of previous one?

[Zachary Kuznia, 2012-11-21 08:07:11]

https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:34: shell_delegate->GetScreenMagnifierType() ==
ash::MAGNIFIER_FULL);
!= ash::MAGNIFIER_NONE

https://codereview.chromium.org/11415025/diff/1026/chrome/browser/ui/ash/chro...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/11415025/diff/1026/chrome/browser/ui/ash/chro...
chrome/browser/ui/ash/chrome_shell_delegate.cc:348: return false;
return ash::MAGNIFIER_NONE

[yoshiki, 2012-11-21 14:48:04]

PTAL. Thanks,

https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:34: shell_delegate->GetScreenMagnifierType() ==
ash::MAGNIFIER_FULL);
On 2012/11/21 08:07:12, Zachary Kuznia wrote:
> != ash::MAGNIFIER_NONE

Done.

https://codereview.chromium.org/11415025/diff/1026/chrome/browser/ui/ash/chro...
File chrome/browser/ui/ash/chrome_shell_delegate.cc (right):

https://codereview.chromium.org/11415025/diff/1026/chrome/browser/ui/ash/chro...
chrome/browser/ui/ash/chrome_shell_delegate.cc:348: return false;
On 2012/11/21 08:07:12, Zachary Kuznia wrote:
> return ash::MAGNIFIER_NONE

Done.

[Nikita (slow), 2012-11-21 16:48:48]

https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
File ash/magnifier/magnifier_constants.h (right):

https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
ash/magnifier/magnifier_constants.h:11: MAGNIFIER_OFF,
I thought that screen magnifier only has on/off functionality.
As in mocks here:
https://drive.google.com/a/google.com/?tab=mo#folders/0B4MawythiAX4MmdnUkk0bW...

[Zachary Kuznia, 2012-11-22 03:44:03]

On 2012/11/21 16:48:48, Nikita Kostylev wrote:
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> File ash/magnifier/magnifier_constants.h (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> ash/magnifier/magnifier_constants.h:11: MAGNIFIER_OFF,
> I thought that screen magnifier only has on/off functionality.
> As in mocks here:
>
https://drive.google.com/a/google.com/?tab=mo#folders/0B4MawythiAX4MmdnUkk0bW...

The partial magnifier was recently added.  It won't be released in m25, though,
so the UI in the Ubar tray will only support on/off functionality for now.

[Zachary Kuznia, 2012-11-22 03:44:24]

lgtm

[yoshiki, 2012-11-22 23:53:59]

On 2012/11/22 03:44:03, Zachary Kuznia wrote:
> On 2012/11/21 16:48:48, Nikita Kostylev wrote:
> >
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> > File ash/magnifier/magnifier_constants.h (right):
> > 
> >
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> > ash/magnifier/magnifier_constants.h:11: MAGNIFIER_OFF,
> > I thought that screen magnifier only has on/off functionality.
> > As in mocks here:
> >
>
https://drive.google.com/a/google.com/?tab=mo#folders/0B4MawythiAX4MmdnUkk0bW...
> 
> The partial magnifier was recently added.  It won't be released in m25,
though,
> so the UI in the Ubar tray will only support on/off functionality for now.

We will add some UI to switch FULL/PARTIAL into the uber tray after M25 branch
is cut. The design is under discussion.

[yoshiki, 2012-11-22 23:55:01]

Hi, @darat, @stevenjb, @jhawkins. Could you take a look and approve?

derat: 
- ash/* (except ash/system)
- chrome/browser/ui/ash/* 
stevenjb:
- ash/system/*
jhawkins:
- chrome/browser/ui/webui/options/browser_options_handler.cc

[Nikita (slow), 2012-11-23 07:30:53]

On 2012/11/22 23:53:59, yoshiki wrote:
> On 2012/11/22 03:44:03, Zachary Kuznia wrote:
> > On 2012/11/21 16:48:48, Nikita Kostylev wrote:
> > >
> >
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> > > File ash/magnifier/magnifier_constants.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> > > ash/magnifier/magnifier_constants.h:11: MAGNIFIER_OFF,
> > > I thought that screen magnifier only has on/off functionality.
> > > As in mocks here:
> > >
> >
>
https://drive.google.com/a/google.com/?tab=mo#folders/0B4MawythiAX4MmdnUkk0bW...
> > 
> > The partial magnifier was recently added.  It won't be released in m25,
> though,
> > so the UI in the Ubar tray will only support on/off functionality for now.
> 
> We will add some UI to switch FULL/PARTIAL into the uber tray after M25 branch
> is cut. The design is under discussion.

Ok, I'll keep checkbox in out-of-box flow accessibility menu.

[Daniel Erat, 2012-11-25 21:22:09]

https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd
File ash/ash_strings.grd (right):

https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcod...
ash/ash_strings.grd:410: <message name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE"
desc="The label used in the title of the accesibility option menu.">
nit: s/accesibility/accessibility/

same below

https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcod...
ash/ash_strings.grd:414: system tray to toggle switch on/off spoken feedback
feature.">
nit: s/toggle switch/toggle/ or /switch/ (i.e. one but not both)

same below

https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
File ash/magnifier/magnifier_constants.h (right):

https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
ash/magnifier/magnifier_constants.h:10: enum ScreenMagnifierType {
do you need to keep "Screen" in the enum name here, or can it be removed?  it
feels strange to have it when neither the filename nor the enum values include
the word "screen"

https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h#newco...
ash/shell_delegate.h:135: // Invoked when the user toggles high contrast for
accessibility.
i'd reword this to "Invoked to toggle high contrast for accessibility.";
otherwise it sounds like it's something that observes the change rather than the
method that's actually called to do the toggling

see also SetScreenMagnifier's comment

https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h#newco...
ash/shell_delegate.h:149: virtual bool AlwaysShowAccessibilityMenu() const = 0;
rename this to something like ShouldAlwaysShowAccessibilityMenu or
GetAlwaysShowAccessibilityMenu(); otherwise it sounds like it will make us
always show the menu instead of just querying the state

https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:69: 
nit: remove extra blank line

https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:105: shell_delegate &&
shell_delegate->IsSpokenFeedbackEnabled();
do you need all of these shell_delegate tests?  when is the shell created with a
null delegate?  also note that you're not testing for a null delegate in e.g.
ClickedOn().

https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
File ash/system/tray_accessibility.h (right):

https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
ash/system/tray_accessibility.h:53: bool previous_accessibility_status_;
"status" is a bit vague here; naming this something like
"accessibility_previously_enabled_" would probably be better

https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
File chrome/browser/chromeos/accessibility/accessibility_util.cc (right):

https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
chrome/browser/chromeos/accessibility/accessibility_util.cc:303:
chrome::ShowSingletonTab(browser, url);
nit: just do:

  chrome::ShowSingletonTab(browser, GURL(chrome::kChromeAccessibilityHelpURL));

if it fits on a single line

https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
File chrome/browser/chromeos/accessibility/accessibility_util.h (right):

https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
chrome/browser/chromeos/accessibility/accessibility_util.h:9: #include
"ash/magnifier/magnifier_constants.h"
nit: add blank line between system header and this one

https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
chrome/browser/chromeos/accessibility/accessibility_util.h:60: // Show the
accessibility help tab on the browser.
nit: s/Show/Shows/

[yoshiki, 2012-11-26 04:54:12]

https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcod...
> ash/ash_strings.grd:410: <message
name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE"
> desc="The label used in the title of the accesibility option menu.">
> nit: s/accesibility/accessibility/
> 
> same below

Done.

>
https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcod...
> ash/ash_strings.grd:414: system tray to toggle switch on/off spoken feedback
> feature.">
> nit: s/toggle switch/toggle/ or /switch/ (i.e. one but not both)
> 
> same below

Done

>
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_co...
> ash/magnifier/magnifier_constants.h:10: enum ScreenMagnifierType {
> do you need to keep "Screen" in the enum name here, or can it be removed?  it
> feels strange to have it when neither the filename nor the enum values include
> the word "screen"

Removed "Screen" from the enum name.

> https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h
> File ash/shell_delegate.h (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h#newco...
> ash/shell_delegate.h:135: // Invoked when the user toggles high contrast for
> accessibility.
> i'd reword this to "Invoked to toggle high contrast for accessibility.";
> otherwise it sounds like it's something that observes the change rather than
the
> method that's actually called to do the toggling
> 
> see also SetScreenMagnifier's comment

Done.
 
>
https://codereview.chromium.org/11415025/diff/2025/ash/shell_delegate.h#newco...
> ash/shell_delegate.h:149: virtual bool AlwaysShowAccessibilityMenu() const =
0;
> rename this to something like ShouldAlwaysShowAccessibilityMenu or
> GetAlwaysShowAccessibilityMenu(); otherwise it sounds like it will make us
> always show the menu instead of just querying the state

Done. I renamed it to ShouldAlwaysShowAccessibilityMenu(). I think
"Should...()_" is more common for the boolean methods like this.

>
https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
> File ash/system/tray_accessibility.cc (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
> ash/system/tray_accessibility.cc:69: 
> nit: remove extra blank line

Done.

>
https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
> ash/system/tray_accessibility.cc:105: shell_delegate &&
> shell_delegate->IsSpokenFeedbackEnabled();
> do you need all of these shell_delegate tests?  when is the shell created with
a
> null delegate?  also note that you're not testing for a null delegate in e.g.
> ClickedOn().

I removed these checks. Ash::Shell is created with delegate, so delegate should
not be null. And I added the DCHECK()s at the constractor TrayAccessibility, in
case of further changes around Shell::delegate() and/or Shell::system_tray().

>
https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
> File ash/system/tray_accessibility.h (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/ash/system/tray_accessibil...
> ash/system/tray_accessibility.h:53: bool previous_accessibility_status_;
> "status" is a bit vague here; naming this something like
> "accessibility_previously_enabled_" would probably be better

Done.

>
https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
> File chrome/browser/chromeos/accessibility/accessibility_util.cc (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
> chrome/browser/chromeos/accessibility/accessibility_util.cc:303:
> chrome::ShowSingletonTab(browser, url);
> nit: just do:
> 
>   chrome::ShowSingletonTab(browser,
GURL(chrome::kChromeAccessibilityHelpURL));
> 
> if it fits on a single line

Done. Thanks,

>
https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
> File chrome/browser/chromeos/accessibility/accessibility_util.h (right):
> 
>
https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
> chrome/browser/chromeos/accessibility/accessibility_util.h:9: #include
> "ash/magnifier/magnifier_constants.h"
> nit: add blank line between system header and this one

Done.

>
https://codereview.chromium.org/11415025/diff/2025/chrome/browser/chromeos/ac...
> chrome/browser/chromeos/accessibility/accessibility_util.h:60: // Show the
> accessibility help tab on the browser.
> nit: s/Show/Shows/

Done.

[yoshiki, 2012-11-26 04:58:23]

Oops, I made a mistake and I deleted the former "Patchset #3", which detat@ has
reviewed, sorry.

[Daniel Erat, 2012-11-26 18:11:39]

lgtm

https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h#newco...
ash/shell_delegate.h:146: virtual void SetScreenMagnifier(MagnifierType type) =
0;
nit: should probably be renamed to SetMagnifierType() to match
GetMagnifierType()

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:314: bool current_accessibility_status =
IsAnyAccessibilityFeatureEnabled();
nit: rename to accessibility_enabled?

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:316: // Show popup if the accessibily status is
being changed to true from false.
nit: accessibility

[stevenjb, 2012-11-26 19:32:10]

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:39: SystemTrayDelegate* tray_delegate =
Shell::GetInstance()->tray_delegate();
tray_delegate() is safe to call outside of destructors, so this wrapper is
unnecessary, just use
Shell::GetInstance()->tray_delegate()->GetUserLoginStatus().

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:85: login_ = login;
login_(login)

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:97: }
Make WS consistent with ~DefaultAccessibilityView()

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:139: -1);
Comment -1 or use an appropriately named const

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:141: views::View* bottom_row = new View();
nit: Construct bottom_row before layout (makes the code slightly easier to
follow)

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:173:
Shell::GetInstance()->system_tray()->ShowDefaultView(BUBBLE_USE_EXISTING);
Use owner->system_tray() instead of Shell::GetInstance()->system_tray()

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:192: }
nit: {} unnecessary

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:210: 10,
Use a const for 10

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:243: DCHECK(system_tray ==
Shell::GetInstance()->system_tray());
We are planning to deprecate Shell::GetInstance()->system_tray(), use
system_tray() instead. It should be safe for there to be more than one system
tray (one per monitor; each system tray will have its own TrayAccessibility
instance).

[yoshiki, 2012-11-28 12:35:28]

@stevenjb: PTAL

https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h
File ash/shell_delegate.h (right):

https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h#newco...
ash/shell_delegate.h:146: virtual void SetScreenMagnifier(MagnifierType type) =
0;
On 2012/11/26 18:11:39, Daniel Erat wrote:
> nit: should probably be renamed to SetMagnifierType() to match
> GetMagnifierType()

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
File ash/system/tray_accessibility.cc (right):

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:39: SystemTrayDelegate* tray_delegate =
Shell::GetInstance()->tray_delegate();
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> tray_delegate() is safe to call outside of destructors, so this wrapper is
> unnecessary, just use
> Shell::GetInstance()->tray_delegate()->GetUserLoginStatus().

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:85: login_ = login;
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> login_(login)

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:97: }
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> Make WS consistent with ~DefaultAccessibilityView()

Done. (WS means curly brackets, right?)

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:139: -1);
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> Comment -1 or use an appropriately named const

Done. And changed network_list_detailed_view_base.cc as well.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:141: views::View* bottom_row = new View();
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> nit: Construct bottom_row before layout (makes the code slightly easier to
> follow)

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:173:
Shell::GetInstance()->system_tray()->ShowDefaultView(BUBBLE_USE_EXISTING);
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> Use owner->system_tray() instead of Shell::GetInstance()->system_tray()

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:192: }
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> nit: {} unnecessary

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:210: 10,
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> Use a const for 10

I removed this part by using TrayNotificationView.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:243: DCHECK(system_tray ==
Shell::GetInstance()->system_tray());
On 2012/11/26 19:32:11, stevenjb (chromium) wrote:
> We are planning to deprecate Shell::GetInstance()->system_tray(), use
> system_tray() instead. It should be safe for there to be more than one system
> tray (one per monitor; each system tray will have its own TrayAccessibility
> instance).

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:314: bool current_accessibility_status =
IsAnyAccessibilityFeatureEnabled();
On 2012/11/26 18:11:39, Daniel Erat wrote:
> nit: rename to accessibility_enabled?

Done.

https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibil...
ash/system/tray_accessibility.cc:316: // Show popup if the accessibily status is
being changed to true from false.
On 2012/11/26 18:11:39, Daniel Erat wrote:
> nit: accessibility

Done.

[stevenjb, 2012-11-28 17:53:21]

lgtm

[commit-bot: I haz the power, 2012-11-28 18:27:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/16039

[commit-bot: I haz the power, 2012-11-28 18:28:22]

Presubmit check for 11415025-16039 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/resources/options
    chrome/browser/ui/webui/chromeos/login
    chrome/browser/ui/webui/options

Presubmit checks took 4.0s to calculate.

[commit-bot: I haz the power, 2012-11-29 01:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/16039

[commit-bot: I haz the power, 2012-11-29 02:17:38]

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-11-29 02:46:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/14042

[commit-bot: I haz the power, 2012-11-29 06:11:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/3041

[commit-bot: I haz the power, 2012-11-29 09:43:01]

Retried try job too often on win_rel for step(s) browser_tests