Chromium Code Reviews
Help | Chromium Project | Sign in
(49)

Issue 11415025: A11y: Introduce High Contrast Mode and Screen Magnifier to ubar tray. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by yoshiki
Modified:
1 year, 4 months ago
CC:
chromium-reviews_chromium.org, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, zork+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

A11y: Introduce High Contrast Mode and Screen Magnifier to ubar tray.

This patch add a sub-menu to set accessibility feature (spoken feedback, high-contrast and screen magnifier) under accessibility menu.

The design is at http://crbug.com/158281.

BUG=160689, 158307
TEST=manual

TBR=nkostylev@chromium.org, jhawkins@chromium.org
# TBRing for just rename changes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170180

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : rebase @169399 #

Patch Set 4 : review fix (comment #10) #

Total comments: 24

Patch Set 5 : rebase @169813 #

Patch Set 6 : review fix (#13, #14) #

Patch Set 7 : rebase @170115 #

Patch Set 8 : rebase @170134 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -161 lines) Lint Patch
M ash/ash.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments ? errors Download
M ash/ash_strings.grd View 1 2 3 4 5 6 1 chunk +21 lines, -2 lines 0 comments ? errors Download
A ash/magnifier/magnifier_constants.h View 1 2 3 1 chunk +18 lines, -0 lines 0 comments 1 errors Download
M ash/shell/shell_delegate_impl.h View 1 2 3 4 5 6 2 chunks +7 lines, -0 lines 0 comments ? errors Download
M ash/shell/shell_delegate_impl.cc View 1 2 3 4 5 6 7 2 chunks +23 lines, -1 line 0 comments 0 errors Download
M ash/shell_delegate.h View 1 2 3 4 5 6 2 chunks +18 lines, -2 lines 0 comments ? errors Download
M ash/system/chromeos/network/network_list_detailed_view_base.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments ? errors Download
M ash/system/tray/system_tray_delegate.h View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M ash/system/tray/system_tray_notifier.h View 1 2 1 chunk +1 line, -1 line 0 comments ? errors Download
M ash/system/tray/system_tray_notifier.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments ? errors Download
M ash/system/tray/test_system_tray_delegate.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M ash/system/tray/test_system_tray_delegate.cc View 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M ash/system/tray/tray_constants.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M ash/system/tray/tray_constants.cc View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments ? errors Download
M ash/system/tray_accessibility.h View 1 2 3 3 chunks +12 lines, -3 lines 0 comments ? errors Download
M ash/system/tray_accessibility.cc View 1 2 3 4 5 3 chunks +236 lines, -44 lines 0 comments 3 errors Download
M ash/test/test_shell_delegate.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -0 lines 0 comments ? errors Download
M ash/test/test_shell_delegate.cc View 1 2 3 4 5 6 2 chunks +22 lines, -0 lines 0 comments ? errors Download
M chrome/browser/chromeos/accessibility/accessibility_util.h View 1 2 3 4 5 3 chunks +18 lines, -22 lines 0 comments ? errors Download
M chrome/browser/chromeos/accessibility/accessibility_util.cc View 1 2 3 4 5 4 chunks +20 lines, -13 lines 0 comments ? errors Download
M chrome/browser/chromeos/accessibility/magnification_manager.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 2 3 4 5 4 chunks +20 lines, -16 lines 0 comments ? errors Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 1 2 3 4 5 4 chunks +19 lines, -19 lines 0 comments ? errors Download
M chrome/browser/chromeos/preferences.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 2 3 4 5 6 6 chunks +21 lines, -8 lines 0 comments ? errors Download
M chrome/browser/resources/options/browser_options.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments ? errors Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 3 5 1 chunk +4 lines, -4 lines 0 comments ? errors Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments ? errors Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 6 7 2 chunks +39 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 1 2 3 4 5 2 chunks +5 lines, -6 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments ? errors Download
M chrome/common/pref_names.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/common/pref_names.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments ? errors Download
M chrome/common/url_constants.h View 1 2 1 chunk +5 lines, -0 lines 0 comments ? errors Download
M chrome/common/url_constants.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 23
yoshiki
zork: could you take a first look at this CL, instead of previous one?
1 year, 5 months ago #1
Zachary Kuznia
https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibility.cc File ash/system/tray_accessibility.cc (right): https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibility.cc#newcode34 ash/system/tray_accessibility.cc:34: shell_delegate->GetScreenMagnifierType() == ash::MAGNIFIER_FULL); != ash::MAGNIFIER_NONE https://codereview.chromium.org/11415025/diff/1026/chrome/browser/ui/ash/chrome_shell_delegate.cc File chrome/browser/ui/ash/chrome_shell_delegate.cc (right): ...
1 year, 4 months ago #2
yoshiki
PTAL. Thanks, https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibility.cc File ash/system/tray_accessibility.cc (right): https://codereview.chromium.org/11415025/diff/1026/ash/system/tray_accessibility.cc#newcode34 ash/system/tray_accessibility.cc:34: shell_delegate->GetScreenMagnifierType() == ash::MAGNIFIER_FULL); On 2012/11/21 08:07:12, Zachary ...
1 year, 4 months ago #3
Nikita Kostylev
https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_constants.h File ash/magnifier/magnifier_constants.h (right): https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_constants.h#newcode11 ash/magnifier/magnifier_constants.h:11: MAGNIFIER_OFF, I thought that screen magnifier only has on/off ...
1 year, 4 months ago #4
Zachary Kuznia
On 2012/11/21 16:48:48, Nikita Kostylev wrote: > https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_constants.h > File ash/magnifier/magnifier_constants.h (right): > > https://codereview.chromium.org/11415025/diff/2025/ash/magnifier/magnifier_constants.h#newcode11 ...
1 year, 4 months ago #5
Zachary Kuznia
lgtm
1 year, 4 months ago #6
yoshiki
On 2012/11/22 03:44:03, Zachary Kuznia wrote: > On 2012/11/21 16:48:48, Nikita Kostylev wrote: > > ...
1 year, 4 months ago #7
yoshiki
Hi, @darat, @stevenjb, @jhawkins. Could you take a look and approve? derat: - ash/* (except ...
1 year, 4 months ago #8
Nikita Kostylev
On 2012/11/22 23:53:59, yoshiki wrote: > On 2012/11/22 03:44:03, Zachary Kuznia wrote: > > On ...
1 year, 4 months ago #9
Daniel Erat
https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd File ash/ash_strings.grd (right): https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcode410 ash/ash_strings.grd:410: <message name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE" desc="The label used in the title of ...
1 year, 4 months ago #10
yoshiki
https://codereview.chromium.org/11415025/diff/2025/ash/ash_strings.grd#newcode410 > ash/ash_strings.grd:410: <message name="IDS_ASH_STATUS_TRAY_ACCESSIBILITY_TITLE" > desc="The label used in the title of the accesibility ...
1 year, 4 months ago #11
yoshiki
Oops, I made a mistake and I deleted the former "Patchset #3", which detat@ has ...
1 year, 4 months ago #12
Daniel Erat
lgtm https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h File ash/shell_delegate.h (right): https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h#newcode146 ash/shell_delegate.h:146: virtual void SetScreenMagnifier(MagnifierType type) = 0; nit: should ...
1 year, 4 months ago #13
stevenjb
https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibility.cc File ash/system/tray_accessibility.cc (right): https://codereview.chromium.org/11415025/diff/2027/ash/system/tray_accessibility.cc#newcode39 ash/system/tray_accessibility.cc:39: SystemTrayDelegate* tray_delegate = Shell::GetInstance()->tray_delegate(); tray_delegate() is safe to call ...
1 year, 4 months ago #14
yoshiki
@stevenjb: PTAL https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h File ash/shell_delegate.h (right): https://codereview.chromium.org/11415025/diff/2027/ash/shell_delegate.h#newcode146 ash/shell_delegate.h:146: virtual void SetScreenMagnifier(MagnifierType type) = 0; On ...
1 year, 4 months ago #15
stevenjb
lgtm
1 year, 4 months ago #16
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/16039
1 year, 4 months ago #17
I haz the power (commit-bot)
Presubmit check for 11415025-16039 failed and returned exit status 1. Running presubmit commit checks ...
1 year, 4 months ago #18
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/16039
1 year, 4 months ago #19
I haz the power (commit-bot)
Step "update" is always a major failure. Look at the try server FAQ for more ...
1 year, 4 months ago #20
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/14042
1 year, 4 months ago #21
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/11415025/3041
1 year, 4 months ago #22
I haz the power (commit-bot)
1 year, 4 months ago #23
Retried try job too often on win_rel for step(s) browser_tests
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434