Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2504)

Unified Diff: content/public/browser/web_contents.h

Issue 1141453003: Fix setting the top-level FrameTreeNode name for named windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Alex's review. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index a28df1cd6ad0fb47078d93336d48f92eabdad79a..62f09a8f47ca151e0743309be0a58979b8dcdeb6 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -110,6 +110,11 @@ class WebContents : public PageNavigator,
int routing_id;
int main_frame_routing_id;
+ // The name of the top-level frame of the new window. It is non-empty
+ // when creating a named window (e.g. <a target="foo"> or
+ // window.open('', 'bar')).
+ std::string main_frame_name;
+
// Initial size of the new WebContent's view. Can be (0, 0) if not needed.
gfx::Size initial_size;

Powered by Google App Engine
This is Rietveld 408576698