Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Side by Side Diff: content/public/browser/web_contents.h

Issue 1141453003: Fix setting the top-level FrameTreeNode name for named windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes based on Alex's review. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // If the opener is suppressed, then the new WebContents doesn't hold a 103 // If the opener is suppressed, then the new WebContents doesn't hold a
104 // reference to its opener. 104 // reference to its opener.
105 bool opener_suppressed; 105 bool opener_suppressed;
106 106
107 // The routing ids of the RenderView and of the main RenderFrame. Either 107 // The routing ids of the RenderView and of the main RenderFrame. Either
108 // both must be provided, or both must be MSG_ROUTING_NONE to have the 108 // both must be provided, or both must be MSG_ROUTING_NONE to have the
109 // WebContents make the assignment. 109 // WebContents make the assignment.
110 int routing_id; 110 int routing_id;
111 int main_frame_routing_id; 111 int main_frame_routing_id;
112 112
113 // The name of the top-level frame of the new window. It is non-empty
114 // when creating a named window (e.g. <a target="foo"> or
115 // window.open('', 'bar')).
116 std::string main_frame_name;
117
113 // Initial size of the new WebContent's view. Can be (0, 0) if not needed. 118 // Initial size of the new WebContent's view. Can be (0, 0) if not needed.
114 gfx::Size initial_size; 119 gfx::Size initial_size;
115 120
116 // True if the contents should be initially hidden. 121 // True if the contents should be initially hidden.
117 bool initially_hidden; 122 bool initially_hidden;
118 123
119 // If non-null then this WebContents will be hosted by a BrowserPlugin. 124 // If non-null then this WebContents will be hosted by a BrowserPlugin.
120 BrowserPluginGuestDelegate* guest_delegate; 125 BrowserPluginGuestDelegate* guest_delegate;
121 126
122 // Used to specify the location context which display the new view should 127 // Used to specify the location context which display the new view should
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
654 659
655 private: 660 private:
656 // This interface should only be implemented inside content. 661 // This interface should only be implemented inside content.
657 friend class WebContentsImpl; 662 friend class WebContentsImpl;
658 WebContents() {} 663 WebContents() {}
659 }; 664 };
660 665
661 } // namespace content 666 } // namespace content
662 667
663 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 668 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698