Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc

Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync with trunk Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
index d584b10953ebe217b9fe5ac9d6c0d1fce69069a7..207d45f81634f2d40bb731a2988bc36c6f965f60 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc
@@ -274,8 +274,8 @@ TEST_F(WebRequestRulesRegistryTest, AddRulesImpl) {
GURL http_url("http://www.example.com");
net::TestURLRequestContext context;
net::TestURLRequest http_request(http_url, NULL, &context);
- matches = registry->GetMatches(
- DeclarativeWebRequestData(&http_request, ON_BEFORE_REQUEST));
+ DeclarativeWebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
+ matches = registry->GetMatches(&request_data);
EXPECT_EQ(2u, matches.size());
std::set<WebRequestRule::GlobalRuleId> matches_ids;
@@ -287,8 +287,8 @@ TEST_F(WebRequestRulesRegistryTest, AddRulesImpl) {
GURL foobar_url("http://www.foobar.com");
net::TestURLRequest foobar_request(foobar_url, NULL, &context);
- matches = registry->GetMatches(
- DeclarativeWebRequestData(&foobar_request, ON_BEFORE_REQUEST));
+ request_data.request = &foobar_request;
+ matches = registry->GetMatches(&request_data);
EXPECT_EQ(1u, matches.size());
WebRequestRule::GlobalRuleId expected_pair =
std::make_pair(kExtensionId, kRuleId2);
@@ -413,11 +413,9 @@ TEST_F(WebRequestRulesRegistryTest, Precedences) {
GURL url("http://www.google.com");
net::TestURLRequestContext context;
net::TestURLRequest request(url, NULL, &context);
+ DeclarativeWebRequestData request_data(&request, ON_BEFORE_REQUEST);
std::list<LinkedPtrEventResponseDelta> deltas =
- registry->CreateDeltas(
- NULL,
- DeclarativeWebRequestData(&request, ON_BEFORE_REQUEST),
- false);
+ registry->CreateDeltas(NULL, &request_data, false);
// The second extension is installed later and will win for this reason
// in conflict resolution.
@@ -463,11 +461,9 @@ TEST_F(WebRequestRulesRegistryTest, Priorities) {
GURL url("http://www.google.com/index.html");
net::TestURLRequestContext context;
net::TestURLRequest request(url, NULL, &context);
+ DeclarativeWebRequestData request_data(&request, ON_BEFORE_REQUEST);
std::list<LinkedPtrEventResponseDelta> deltas =
- registry->CreateDeltas(
- NULL,
- DeclarativeWebRequestData(&request, ON_BEFORE_REQUEST),
- false);
+ registry->CreateDeltas(NULL, &request_data, false);
// The redirect by the first extension is ignored due to the ignore rule.
ASSERT_EQ(1u, deltas.size());
@@ -507,8 +503,8 @@ TEST_F(WebRequestRulesRegistryTest, GetMatchesCheckFulfilled) {
GURL http_url("http://www.example.com");
net::TestURLRequestContext context;
net::TestURLRequest http_request(http_url, NULL, &context);
- matches = registry->GetMatches(
- DeclarativeWebRequestData(&http_request, ON_BEFORE_REQUEST));
+ DeclarativeWebRequestData request_data(&http_request, ON_BEFORE_REQUEST);
+ matches = registry->GetMatches(&request_data);
EXPECT_EQ(1u, matches.size());
WebRequestRule::GlobalRuleId expected_pair = std::make_pair(kExtensionId,
kRuleId3);

Powered by Google App Engine
This is Rietveld 408576698