Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: chrome/common/extensions/api/declarative_web_request.json

Issue 11414230: Declarative Web Request: firstPartyForCookiesUrl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync with trunk Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/declarative_web_request.json
diff --git a/chrome/common/extensions/api/declarative_web_request.json b/chrome/common/extensions/api/declarative_web_request.json
index 2d781a95ff3baa3b9cb4cf046fea24d83c93cbfd..715d8341e6eba35b4f261cc18665bfa68ce59551 100644
--- a/chrome/common/extensions/api/declarative_web_request.json
+++ b/chrome/common/extensions/api/declarative_web_request.json
@@ -67,7 +67,12 @@
"properties": {
"url": {
"$ref": "events.UrlFilter",
- "description": "Matches if the condition of the UrlFilter are fulfilled for the URL of the request.",
+ "description": "Matches if the conditions of the UrlFilter are fulfilled for the URL of the request.",
+ "optional": true
+ },
+ "firstPartyForCookiesUrl": {
+ "$ref": "events.UrlFilter",
+ "description": "Matches if the conditions of the UrlFilter are fulfilled for the URL representing first party for cookies.",
Jeffrey Yasskin 2013/01/24 00:39:17 As a fairly naive user of this API, "representing
vabr (Chromium) 2013/01/24 18:24:08 Done. How does that sound now?
Jeffrey Yasskin 2013/01/24 19:54:46 Not great, sorry to say. Again, go ahead and submi
vabr (Chromium) 2013/01/24 21:12:19 I agree. Unless Yoyo, who I need to review this fi
"optional": true
},
"resourceType": {

Powered by Google App Engine
This is Rietveld 408576698