Issue 11414101: This adds ManagedNetworkConfigurationHandler first pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414101: This adds ManagedNetworkConfigurationHandler first pass (Closed)

Created:
8 years, 1 month ago by Greg Spencer (Chromium)

Modified:
7 years, 10 months ago

Reviewers:

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This adds ManagedNetworkConfigurationHandler first pass So that we can manage network configurations via GUID instead of using Shill's service paths. BUG=chromium:157696

Patch Set 1 #

Patch Set 2 : upload after merge #

Patch Set 3 : upload after merge #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+450 lines, -78 lines)			Patch
M	chrome/browser/chromeos/chrome_browser_main_chromeos.cc	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
M	chromeos/chromeos.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	chromeos/network/managed_network_configuration_handler.h	View	1 2	4 chunks	+38 lines, -32 lines	0 comments	Download
A	chromeos/network/managed_network_configuration_handler.cc	View	1 2	1 chunk	+286 lines, -0 lines	0 comments	Download
M	chromeos/network/network_configuration_handler.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chromeos/network/network_configuration_handler.cc	View	1	3 chunks	+15 lines, -15 lines	0 comments	Download
M	chromeos/network/network_configuration_handler_unittest.cc	View		12 chunks	+12 lines, -13 lines	0 comments	Download
M	chromeos/network/network_state.h	View	1	2 chunks	+6 lines, -2 lines	0 comments	Download
M	chromeos/network/network_state.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chromeos/network/onc/onc_mapper.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/onc/onc_signature.h	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chromeos/network/onc/onc_signature.cc	View	1 2	2 chunks	+17 lines, -2 lines	0 comments	Download
M	chromeos/network/onc/onc_translator.h	View	1	3 chunks	+20 lines, -2 lines	0 comments	Download
M	chromeos/network/onc/onc_translator_onc_to_shill.cc	View	1 2	3 chunks	+20 lines, -4 lines	0 comments	Download
M	chromeos/network/onc/onc_translator_shill_to_onc.cc	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download
M	chromeos/network/onc/onc_translator_unittest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chromeos/network/onc/onc_validator.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

pneubeck (no reviews)

8 years ago (2012-12-03 14:57:35 UTC) #1

Shouldn't the ManagedNetworkConfigurationHandler  be located in
src/chrome/browser/... ?

I see several potential reasons:

The policy class are located in src/chrome/browser/policy.

For the proxy configuration we have to access proxy classes in
src/chrome/browser/chromeos as well as the preferences.

Functions like ConnectTo... will have to call UI functions to gather further
user input.

Expand Messages | Collapse Messages