Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chromeos/network/network_configuration_handler.h

Issue 11414101: This adds ManagedNetworkConfigurationHandler first pass (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: upload after merge Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler.h
diff --git a/chromeos/network/network_configuration_handler.h b/chromeos/network/network_configuration_handler.h
index c7f6a8283b5eddec1b5400152082672b0ea18d1e..2a0098983eba1743fbaabc7f9d2d4a06a1b5e8b8 100644
--- a/chromeos/network/network_configuration_handler.h
+++ b/chromeos/network/network_configuration_handler.h
@@ -25,7 +25,8 @@ namespace chromeos {
// most calls are asynchronous for that reason. No calls will block on DBus
// calls.
//
-// This is owned and it's lifetime managed by aura::Shell.
+// This is owned and it's lifetime managed by the Chrome startup code. It's
+// basically a singleton, but with explicit lifetime management.
//
// For accessing lists of remembered networks, and other state information, see
// the class NetworkStateHandler.
@@ -93,9 +94,8 @@ class CHROMEOS_EXPORT NetworkConfigurationHandler {
// Creates a network with the given properties in the active Shill profile,
- // and returns the properties to |callback| if successful, along with the new
- // service_path. See note on |callback| and |error_callback|, in class
- // description above.
+ // and returns the new service_path to |callback| if successful. See note on
+ // |callback| and |error_callback|, in class description above.
void CreateConfiguration(
const base::DictionaryValue& properties,
const network_handler::StringResultCallback& callback,
« no previous file with comments | « chromeos/network/managed_network_configuration_handler.cc ('k') | chromeos/network/network_configuration_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698