Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11414069: Make mappedBy lazy. (Closed)

Created:
8 years, 1 month ago by floitsch
Modified:
8 years ago
CC:
reviews_dartlang.org, Anders Johnsen
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove CollectionUtils.mappedBy in Swarm. #

Total comments: 8

Patch Set 3 : Make MappedIterable take two generic types. #

Patch Set 4 : Reupload due to error. #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -447 lines) Patch
M pkg/intl/test/date_time_format_file_test_stub.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/intl/test/date_time_format_http_request_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/intl/test/date_time_format_local_test_stub.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/intl/test/date_time_format_test_core.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/lib/array.dart View 1 2 2 chunks +2 lines, -8 lines 4 comments Download
M runtime/lib/byte_array.dart View 1 2 3 chunks +3 lines, -24 lines 2 comments Download
M runtime/lib/growable_array.dart View 1 2 1 chunk +1 line, -4 lines 2 comments Download
M runtime/lib/string_base.dart View 1 chunk +19 lines, -17 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/newissues/newissues.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/DataSource.dart View 1 2 chunks +1 line, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/layout/GridLayout.dart View 1 3 chunks +5 lines, -3 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/util/CollectionUtils.dart View 1 1 chunk +0 lines, -16 lines 0 comments Download
M samples/third_party/dromaeo/Suites.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 chunk +11 lines, -19 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/interceptors.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 1 chunk +1 line, -5 lines 0 comments Download
M sdk/lib/async/future.dart View 2 chunks +16 lines, -9 lines 0 comments Download
M sdk/lib/collection/collections.dart View 1 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 2 2 chunks +67 lines, -12 lines 0 comments Download
M sdk/lib/core/queue.dart View 4 chunks +1 line, -63 lines 0 comments Download
M sdk/lib/core/sequences.dart View 1 2 1 chunk +1 line, -7 lines 0 comments Download
M sdk/lib/core/set.dart View 3 chunks +1 line, -40 lines 0 comments Download
M sdk/lib/core/strings.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 41 chunks +42 lines, -59 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 40 chunks +41 lines, -58 lines 0 comments Download
M sdk/lib/html/src/CssClassSet.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/src/FilteredElementList.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/src/_Collections.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 2 2 chunks +4 lines, -12 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Node.darttemplate View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/html/templates/immutable_list_mixin.darttemplate View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 9 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 9 chunks +9 lines, -9 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +8 lines, -0 lines 0 comments Download
M tests/corelib/list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/queue_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/set_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/xmldocument_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tests/html/xmlelement_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M utils/pub/hosted_source.dart View 1 chunk +3 lines, -1 line 0 comments Download
M utils/pub/utils.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/version.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M utils/pub/version_solver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/pub/yaml/model.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/pub/yaml/parser.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M utils/pub/yaml/visitor.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/pub/yaml/yaml.dart View 1 chunk +2 lines, -1 line 0 comments Download
M utils/pub/yaml/yaml_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/archive/reader_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M utils/tests/pub/test_pub.dart View 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
floitsch
Make mappedBy lazy. https://codereview.chromium.org/11414069/diff/2001/samples/swarm/DataSource.dart File samples/swarm/DataSource.dart (left): https://codereview.chromium.org/11414069/diff/2001/samples/swarm/DataSource.dart#oldcode90 samples/swarm/DataSource.dart:90: List mappedBy(f(Section element)) { Not necessary, ...
8 years, 1 month ago (2012-11-20 01:04:32 UTC) #1
Anders Johnsen
https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode139 sdk/lib/core/iterable.dart:139: MappedIterable(this._iterable, E this._f(element)); this._f(E element) as type https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode144 sdk/lib/core/iterable.dart:144: ...
8 years, 1 month ago (2012-11-20 06:29:15 UTC) #2
floitsch
https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode139 sdk/lib/core/iterable.dart:139: MappedIterable(this._iterable, E this._f(element)); On 2012/11/20 06:29:15, ajohnsen wrote: > ...
8 years, 1 month ago (2012-11-20 13:33:44 UTC) #3
Anders Johnsen
https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode139 sdk/lib/core/iterable.dart:139: MappedIterable(this._iterable, E this._f(element)); On 2012/11/20 13:33:44, floitsch wrote: > ...
8 years, 1 month ago (2012-11-20 13:39:46 UTC) #4
Lasse Reichstein Nielsen
LGTM / rubberstamped. https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode135 sdk/lib/core/iterable.dart:135: class MappedIterable<E> extends Iterable<E> { Make ...
8 years, 1 month ago (2012-11-20 14:11:47 UTC) #5
floitsch
https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/11414069/diff/2001/sdk/lib/core/iterable.dart#newcode135 sdk/lib/core/iterable.dart:135: class MappedIterable<E> extends Iterable<E> { On 2012/11/20 14:11:47, Lasse ...
8 years, 1 month ago (2012-11-20 16:41:26 UTC) #6
Ivan Posva
DBC -ip https://codereview.chromium.org/11414069/diff/10001/runtime/lib/array.dart File runtime/lib/array.dart (right): https://codereview.chromium.org/11414069/diff/10001/runtime/lib/array.dart#newcode70 runtime/lib/array.dart:70: Iterable mappedBy(f(E element)) => new MappedIterable<E, dynamic>(this, ...
8 years ago (2012-11-26 18:29:09 UTC) #7
floitsch
8 years ago (2012-11-28 13:48:23 UTC) #8
Message was sent while issue was closed. 
Ivan's comments are addressed in https://codereview.chromium.org//11416240

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/array.dart
File runtime/lib/array.dart (right):

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/array.dart#ne...
runtime/lib/array.dart:70: Iterable mappedBy(f(E element)) => new
MappedIterable<E, dynamic>(this, f);
On 2012/11/26 18:29:09, Ivan Posva wrote:
> We like our curlys. Please leave them in.

Done.

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/array.dart#ne...
runtime/lib/array.dart:215: Iterable mappedBy(f(E element)) => new
MappedIterable<E, dynamic>(this, f);
On 2012/11/26 18:29:09, Ivan Posva wrote:
> ditto

Done.

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/byte_array.dart
File runtime/lib/byte_array.dart (right):

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/byte_array.da...
runtime/lib/byte_array.dart:1615: class _ByteArrayViewBase extends
Collection<int> {
On 2012/11/26 18:29:09, Ivan Posva wrote:
> Please see previous comment about extra costs of extending vs implementing.

It is much easier if we only have to implement our functions in one place. When
things stabilize we can remove the extend and copy the functions back.
Added a TODO to make sure we don't forget.

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/growable_arra...
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/11414069/diff/10001/runtime/lib/growable_arra...
runtime/lib/growable_array.dart:181: Iterable mappedBy(f(T element)) => new
MappedIterable<T, dynamic>(this, f);
On 2012/11/26 18:29:09, Ivan Posva wrote:
> ditto: curlys

Done.

Powered by Google App Engine
This is Rietveld 408576698