Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 11416240: Address Ivan's comments. (Closed)

Created:
8 years ago by floitsch
Modified:
8 years ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Adressed more of Ivan's comments. #

Patch Set 3 : Fix typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M runtime/lib/array.dart View 1 2 5 chunks +27 lines, -9 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/lib/growable_array.dart View 1 2 3 chunks +12 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/isolate/base.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/utf/utf16.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf32.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf8.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/utf/utf_core.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
8 years ago (2012-11-28 15:01:28 UTC) #1
Anders Johnsen
8 years ago (2012-11-29 08:17:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698