[MIPS] Minor tweaks for QEMU.

[MIPS] Minor tweaks for QEMU.

Correct value of QEMU_JAIL and create symbolic links for libstdc++.so and
libgcc_s.so. This enables correct execution of QEMU.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= run trusted-toolchain-creator.mipsel.squeeze.sh trusted_sdk


Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10314

[Mark Seaborn, 2012-11-17 03:16:44]

LGTM with change below

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:555:
cp ../../../mipsel-linux-gnu/lib/libstdc++.so.6.0.17 .
How about this instead:

ln -s ../../../mipsel-linux-gnu/lib/libstdc++.so.*

Using 'cp' here will increase the size of the toolchain tarball unnecessarily.

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:559:
cp ../../../mipsel-linux-gnu/lib/libgcc_s.so.1 .
Similarly,
ln -s ../../../mipsel-linux-gnu/lib/libgcc_s.so.*

[Mark Seaborn, 2012-11-17 03:17:30]

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:555:
cp ../../../mipsel-linux-gnu/lib/libstdc++.so.6.0.17 .
On 2012/11/17 03:16:44, Mark Seaborn wrote:
> How about this instead:
> 
> ln -s ../../../mipsel-linux-gnu/lib/libstdc++.so.*

I forgot the trailing dot:

ln -s ../../../mipsel-linux-gnu/lib/libstdc++.so.* .

[petarj, 2012-11-20 00:01:41]

Second patch uploaded.

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:555:
cp ../../../mipsel-linux-gnu/lib/libstdc++.so.6.0.17 .
On 2012/11/17 03:16:44, Mark Seaborn wrote:
> How about this instead:
> 
> ln -s ../../../mipsel-linux-gnu/lib/libstdc++.so.*
> 
> Using 'cp' here will increase the size of the toolchain tarball unnecessarily.

Removed cp.

http://codereview.chromium.org/11414047/diff/1/tools/trusted_cross_toolchains...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:559:
cp ../../../mipsel-linux-gnu/lib/libgcc_s.so.1 .
On 2012/11/17 03:16:44, Mark Seaborn wrote:
> Similarly,
> ln -s ../../../mipsel-linux-gnu/lib/libgcc_s.so.*

Removed copy.

[Mark Seaborn, 2012-11-20 00:32:36]

LGTM

http://codereview.chromium.org/11414047/diff/5001/tools/trusted_cross_toolcha...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/11414047/diff/5001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:556:
ln -s libstdc++.so.6.0.17 libstdc++.so.6
I'm not sure why you chose to fix the version number rather than use the
globbing I suggested (which would work regardless of versions), but the above is
fine.

[petarj, 2012-11-20 00:49:11]

http://codereview.chromium.org/11414047/diff/5001/tools/trusted_cross_toolcha...
File tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh
(right):

http://codereview.chromium.org/11414047/diff/5001/tools/trusted_cross_toolcha...
tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh:556:
ln -s libstdc++.so.6.0.17 libstdc++.so.6
On 2012/11/20 00:32:36, Mark Seaborn wrote:
> I'm not sure why you chose to fix the version number rather than use the
> globbing I suggested (which would work regardless of versions), but the above
is
> fine.
I would like to be aware when this code and the versions change, so this is why
I am more in favor of keeping the version numbers here for the time being.

[commit-bot: I haz the power, 2012-11-20 17:40:54]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/11414047/5001

[commit-bot: I haz the power, 2012-11-20 17:40:57]

Presubmit check for 11414047-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2012|2011|2010|2009|2008|2007|2006|2006-2008) The Native
Client Authors\. All rights reserved\.\n.*? Use of this source code is governed
by a BSD-style license that can be\n.*? found in the LICENSE file\.(?: \*/)?\n
Found a bad license header in these files:
  tools/trusted_cross_toolchains/qemu_tool_mips32.sh \
  tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.squeeze.sh

[commit-bot: I haz the power, 2012-11-20 18:09:43]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/11414047/10001

[commit-bot: I haz the power, 2012-11-20 21:19:26]

Change committed as 10314